You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jens Geyer <je...@hotmail.com> on 2019/02/02 13:41:26 UTC

Re: C# changes and a question

@Jim: Could you file a ticket please?


-----Ursprüngliche Nachricht----- 
From: James E. King III
Sent: Tuesday, January 29, 2019 1:25 AM
To: dev@thrift.apache.org
Subject: Re: C# changes and a question

We'll also need to update the NuGet package to property support netstd.
See top level ApacheThrift.nuspec - updated in 0.12.0.

- Jim

On Mon, Jan 28, 2019 at 5:54 PM Jens Geyer <je...@hotmail.com> wrote:

>
> To make it clear: I'm talking about netstd only!
>
> As the plan is to drop C# and netcore after 0.13.0 in favour of netstd,
> there's no point in it to change these.
>
> Thanks again,
> JensG
>
>
> -----Ursprüngliche Nachricht-----
> From: Jens Geyer
> Sent: Monday, January 28, 2019 11:43 PM
> To: Thrift-Dev
> Subject: C# changes and a question
>
> @all C# and netcore developers around,
>
> the new “netstd” library has been merged to master!
>
> I tried my best to consolidate the existing libraries into one single
> target
> that suits both ends of the continuum, including a README that gives hints
> to master the migration process from C# or netcore.  Yet there may still
> be
> things to improve, so don’t hesitate to report any problems that you run
> into while migrating to netstd or while using it.
>
> And last not least, here’s a question for you:
>
> ---- QUESTION -------------------------------------------
> Are you using the “nullable” flag and/or could you agree on removing that
> piece nevertheless?
>
> [+1]  REMOVE NULLABLE:  I am either not using it, or could live with
> “nullable” being removed
> [-1]   KEEP NULLABLE: I am using it and absolutely need it.
>
> As a bonus question, in the latter case I would (optionally) be interested
> in the exact reason, why you think it is not an option to remove
> “nullable”.
> --------------------------------------------------------------
>
> Background of this question is, that “nullable” produces a great deal of
> pain maintaining it but provides less added value than initially assumed
> when we introduced it (at least that’s my personal view to the matter). So
> the idea is to remove the “nullable” option entirely from netstd to make
> maintenance of the generator code less painful.
>
> For those wondering: As of today, the “nullable” option is still in the
> code, but inactive, so you currently can’t use it with netstd but requires
> only a few lines of code to re-enable it.
>
>
> Thank you, and have fun
> JensG
>
> 


Re: C# changes and a question

Posted by "James E. King III" <jk...@apache.org>.
https://issues.apache.org/jira/browse/THRIFT-4769

On Sat, Feb 2, 2019 at 8:41 AM Jens Geyer <je...@hotmail.com> wrote:

>
> @Jim: Could you file a ticket please?
>
>
> -----Ursprüngliche Nachricht-----
> From: James E. King III
> Sent: Tuesday, January 29, 2019 1:25 AM
> To: dev@thrift.apache.org
> Subject: Re: C# changes and a question
>
> We'll also need to update the NuGet package to property support netstd.
> See top level ApacheThrift.nuspec - updated in 0.12.0.
>
> - Jim
>
> On Mon, Jan 28, 2019 at 5:54 PM Jens Geyer <je...@hotmail.com> wrote:
>
> >
> > To make it clear: I'm talking about netstd only!
> >
> > As the plan is to drop C# and netcore after 0.13.0 in favour of netstd,
> > there's no point in it to change these.
> >
> > Thanks again,
> > JensG
> >
> >
> > -----Ursprüngliche Nachricht-----
> > From: Jens Geyer
> > Sent: Monday, January 28, 2019 11:43 PM
> > To: Thrift-Dev
> > Subject: C# changes and a question
> >
> > @all C# and netcore developers around,
> >
> > the new “netstd” library has been merged to master!
> >
> > I tried my best to consolidate the existing libraries into one single
> > target
> > that suits both ends of the continuum, including a README that gives
> hints
> > to master the migration process from C# or netcore.  Yet there may still
> > be
> > things to improve, so don’t hesitate to report any problems that you run
> > into while migrating to netstd or while using it.
> >
> > And last not least, here’s a question for you:
> >
> > ---- QUESTION -------------------------------------------
> > Are you using the “nullable” flag and/or could you agree on removing that
> > piece nevertheless?
> >
> > [+1]  REMOVE NULLABLE:  I am either not using it, or could live with
> > “nullable” being removed
> > [-1]   KEEP NULLABLE: I am using it and absolutely need it.
> >
> > As a bonus question, in the latter case I would (optionally) be
> interested
> > in the exact reason, why you think it is not an option to remove
> > “nullable”.
> > --------------------------------------------------------------
> >
> > Background of this question is, that “nullable” produces a great deal of
> > pain maintaining it but provides less added value than initially assumed
> > when we introduced it (at least that’s my personal view to the matter).
> So
> > the idea is to remove the “nullable” option entirely from netstd to make
> > maintenance of the generator code less painful.
> >
> > For those wondering: As of today, the “nullable” option is still in the
> > code, but inactive, so you currently can’t use it with netstd but
> requires
> > only a few lines of code to re-enable it.
> >
> >
> > Thank you, and have fun
> > JensG
> >
> >
>
>