You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Sahil Takiar (Code Review)" <ge...@cloudera.org> on 2020/01/13 23:17:28 UTC
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Sahil Takiar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15027
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
IMPALA-9295: Read aux error info regardless of overall query status
IMPALA-9137 added AuxErrorInfoPB to FragmentInstanceExecStatusPB
in order to propagate additional error information from Impala executors
to coordinators. The extra error information helps the coordinator decide
if it should blacklist any nodes.
Prior to this patch, the aux error info was only read if the
overall_status of the ReportExecStatusRequestPB was an error. However,
Impala executors don't synchronize the setting of the the aux error info
and the overall_status, so it is possible the aux error info is dropped.
This patch fixes this issue by always looking for the aux error info
from each fragment, regardless of the overall_status from the report.
Testing:
* Core tests pass
Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
4 files changed, 28 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/15027/1
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 22:11:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 15 Jan 2020 02:40:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5421/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jan 2020 23:47:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5406/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jan 2020 23:21:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15027
to look at the new patch set (#3).
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
IMPALA-9295: Read aux error info regardless of overall query status
IMPALA-9137 added AuxErrorInfoPB to FragmentInstanceExecStatusPB
in order to propagate additional error information from Impala executors
to coordinators. The extra error information helps the coordinator decide
if it should blacklist any nodes.
Prior to this patch, the aux error info was only read if the
overall_status of the ReportExecStatusRequestPB was an error. However,
Impala executors don't synchronize the setting of the the aux error info
and the overall_status, so it is possible the aux error info is dropped.
This patch fixes this issue by always looking for the aux error info
from each fragment, regardless of the overall_status from the report.
Testing:
* Core tests pass
Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
4 files changed, 28 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/15027/3
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15027
to look at the new patch set (#2).
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
IMPALA-9295: Read aux error info regardless of overall query status
IMPALA-9137 added AuxErrorInfoPB to FragmentInstanceExecStatusPB
in order to propagate additional error information from Impala executors
to coordinators. The extra error information helps the coordinator decide
if it should blacklist any nodes.
Prior to this patch, the aux error info was only read if the
overall_status of the ReportExecStatusRequestPB was an error. However,
Impala executors don't synchronize the setting of the the aux error info
and the overall_status, so it is possible the aux error info is dropped.
This patch fixes this issue by always looking for the aux error info
from each fragment, regardless of the overall_status from the report.
Testing:
* Core tests pass
Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
4 files changed, 28 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/27/15027/2
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5412/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 4
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 22:11:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15027/1/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:
http://gerrit.cloudera.org:8080/#/c/15027/1/be/src/runtime/coordinator.h@552
PS1, Line 552: /// Helper function for UpdateBackendExecStatus that iterates through the given vector
> line has trailing whitespace
Done
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jan 2020 23:19:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5422/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jan 2020 23:48:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/15027/1/be/src/runtime/coordinator.h
File be/src/runtime/coordinator.h:
http://gerrit.cloudera.org:8080/#/c/15027/1/be/src/runtime/coordinator.h@552
PS1, Line 552: /// Helper function for UpdateBackendExecStatus that iterates through the given vector
line has trailing whitespace
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 1
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jan 2020 23:18:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 21:28:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 2:
Test failure is unrelated (IMPALA-1995).
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 16:13:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/5406/
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 2
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 03:54:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Sahil Takiar (Code Review)" <ge...@cloudera.org>.
Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 3: Code-Review+2
Carrying +2
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 22:10:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
IMPALA-9295: Read aux error info regardless of overall query status
IMPALA-9137 added AuxErrorInfoPB to FragmentInstanceExecStatusPB
in order to propagate additional error information from Impala executors
to coordinators. The extra error information helps the coordinator decide
if it should blacklist any nodes.
Prior to this patch, the aux error info was only read if the
overall_status of the ReportExecStatusRequestPB was an error. However,
Impala executors don't synchronize the setting of the the aux error info
and the overall_status, so it is possible the aux error info is dropped.
This patch fixes this issue by always looking for the aux error info
from each fragment, regardless of the overall_status from the report.
Testing:
* Core tests pass
Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Reviewed-on: http://gerrit.cloudera.org:8080/15027
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
4 files changed, 28 insertions(+), 19 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 5
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-9295: Read aux error info regardless of overall query status
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15027 )
Change subject: IMPALA-9295: Read aux error info regardless of overall query status
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5430/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15027
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7dfb5efd7a70626dfc5227f28288ff52ebb4861a
Gerrit-Change-Number: 15027
Gerrit-PatchSet: 3
Gerrit-Owner: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Jan 2020 22:40:31 +0000
Gerrit-HasComments: No