[GitHub] [superset] rusackas commented on pull request #16408: Revert "fix(explore): let admin overwrite slice"

[GitBox <gi...@apache.org>]

rusackas commented on pull request #16408:
URL: https://github.com/apache/superset/pull/16408#issuecomment-904026786


   Note that reverting this will probably bring some of the bugs that it was intended to solve. There were some issues with (Admin) users seeing 403/404 errors when the clicking Save/Overwrite button on charts they did not own. This fix made it actually work, when perhaps the more prudent approach would be to figure out why the action was enabled in the first place, and find a more proper means to disable that Overwrite action. More research is warranted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org