[GitHub] [flink] dawidwys commented on pull request #19198: [FLINK-26783] Restore from a stop-with-savepoint if failed during committing

[GitBox <gi...@apache.org>]

dawidwys commented on pull request #19198:
URL: https://github.com/apache/flink/pull/19198#issuecomment-1077370537


   After an offline discussion we said that indeed this approach poses a problem for the savepoint ownership, as after a restart the savepoint will remain in the `CompletedCheckpointStore` and Flink will depend on its existence.
   
   Therefore we propose a different approach to solve the issue that if we fallback to a checkpoint we might end up with duplicated records. We suggest to already not trigger a global failover in case the savepoint completed successfully, but the job failed during committing side effects. In that case we will finish the completable future with an exception that explains that the savepoint is consistent, but it might have uncommitted side effects and ask users to manually restart a job from that savepoint if they want to commit side effects.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org