You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Daniel Wong (JIRA)" <ji...@apache.org> on 2019/05/07 22:10:00 UTC
[jira] [Commented] (PHOENIX-5273) Singleton ConnectionQueryServices
for UpdateCacheAcrossDifferentClientsIT
[ https://issues.apache.org/jira/browse/PHOENIX-5273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16835153#comment-16835153 ]
Daniel Wong commented on PHOENIX-5273:
--------------------------------------
Patch looks fine to me. One nit: We should ensure the exception is coming from the rs.next() not from the createStatement as we discussed offline.
> Singleton ConnectionQueryServices for UpdateCacheAcrossDifferentClientsIT
> -------------------------------------------------------------------------
>
> Key: PHOENIX-5273
> URL: https://issues.apache.org/jira/browse/PHOENIX-5273
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.14.1
> Reporter: Daniel Wong
> Assignee: Thomas D'Silva
> Priority: Minor
> Fix For: 4.15.0
>
> Attachments: PHOENIX-5273-4.x-HBase-1.3.patch
>
>
> While I was implementing my pluggable stats cache and related work I found that the IT, UpdateCacheAcrossDifferentClientsIT assumes it uses 2 different ConnectionQueryServices. When I was debugging it however I saw that it still had the test properties in the JDBC url which caused it to use the PhoenixTestDriver which has a Singleton for ConnectionQueryServices. When I corrected this error one of the tests started failing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)