You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "pdxrunner (GitHub)" <gi...@apache.org> on 2019/02/05 21:42:51 UTC

[GitHub] [geode] pdxrunner commented on pull request #3156: GEODE-6322: refactor createRegionCommand to use RegionConfig only

The semantics of this is kind of ugly (i.e. non-intuitive). We're testing that a method that returns a Boolean to return null. Yes,  I realize the declared return type (`Boolean`) could be null, but that confuses the intent of a method named `isXxxxx()`

The logic in `public boolean isConcurrencyChecksEnabled()` is more intuitive.

[ Full content available at: https://github.com/apache/geode/pull/3156 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org