You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "TyrantLucifer (via GitHub)" <gi...@apache.org> on 2023/04/22 12:19:39 UTC
[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #4645: [Hotfix][Connector-e2e][File-local] Complete the e2e test case env co…
TyrantLucifer commented on code in PR #4645:
URL: https://github.com/apache/incubator-seatunnel/pull/4645#discussion_r1174403262
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-local-e2e/src/test/resources/excel/local_excel_projection_to_assert.conf:
##########
@@ -42,22 +67,7 @@ source {
c_date = date
c_decimal = "decimal(38, 18)"
c_timestamp = timestamp
- c_row = {
Review Comment:
Why delete it?
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-local-e2e/src/test/resources/excel/local_excel_to_assert.conf:
##########
@@ -51,22 +66,7 @@ source {
c_date = date
c_decimal = "decimal(38, 18)"
c_timestamp = timestamp
- c_row = {
Review Comment:
Why delete it?
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-local-e2e/src/test/resources/excel/local_excel_projection_to_assert.conf:
##########
@@ -18,16 +18,41 @@
###### This config file is a demonstration of streaming processing in seatunnel config
######
+env {
Review Comment:
It's duplicate with #4615 https://github.com/apache/incubator-seatunnel/pull/4615/files#diff-ee22b91619cbf4eea14ae402900bf2bb469e4ad4a2a6d1387af1c3db93d5d7fcR21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org