You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Henri Yandell (JIRA)" <ji...@apache.org> on 2008/01/17 07:24:34 UTC
[jira] Created: (DBCP-254) Possible NPE in PooledConnectionImpl
Possible NPE in PooledConnectionImpl
------------------------------------
Key: DBCP-254
URL: https://issues.apache.org/jira/browse/DBCP-254
Project: Commons Dbcp
Issue Type: Bug
Environment: Fortify
Reporter: Henri Yandell
Fix For: 1.3
makeObject(Object) checks if key._resultSetType and _resultSetConcurrency are both null, but not if one or the other is null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DBCP-254) Possible NPE in PooledConnectionImpl
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559823#action_12559823 ]
Henri Yandell commented on DBCP-254:
------------------------------------
The same is true of PooledConnection's makeObject too.
> Possible NPE in PooledConnectionImpl
> ------------------------------------
>
> Key: DBCP-254
> URL: https://issues.apache.org/jira/browse/DBCP-254
> Project: Commons Dbcp
> Issue Type: Bug
> Environment: Fortify
> Reporter: Henri Yandell
> Fix For: 1.3
>
>
> makeObject(Object) checks if key._resultSetType and _resultSetConcurrency are both null, but not if one or the other is null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DBCP-254) Possible NPE in PooledConnectionImpl
Posted by "Phil Steitz (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560226#action_12560226 ]
Phil Steitz commented on DBCP-254:
----------------------------------
While a little smelly, I think these are both harmless. In the second case, I assume you mean "PoolingConnection. " In both cases, "key" is a PStmtKey (inner class which each, ugh, maintains a copy of), which is immutable and impossible to initialize with one of these fields null and the other not null.
> Possible NPE in PooledConnectionImpl
> ------------------------------------
>
> Key: DBCP-254
> URL: https://issues.apache.org/jira/browse/DBCP-254
> Project: Commons Dbcp
> Issue Type: Bug
> Environment: Fortify
> Reporter: Henri Yandell
> Fix For: 1.3
>
>
> makeObject(Object) checks if key._resultSetType and _resultSetConcurrency are both null, but not if one or the other is null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (DBCP-254) Possible NPE in PooledConnectionImpl
Posted by "Henri Yandell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DBCP-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henri Yandell closed DBCP-254.
------------------------------
Resolution: Won't Fix
Hard to tell - they're no longer listed at Fortify :(
Marking as WONTFIX.
> Possible NPE in PooledConnectionImpl
> ------------------------------------
>
> Key: DBCP-254
> URL: https://issues.apache.org/jira/browse/DBCP-254
> Project: Commons Dbcp
> Issue Type: Bug
> Environment: Fortify
> Reporter: Henri Yandell
> Fix For: 1.3
>
>
> makeObject(Object) checks if key._resultSetType and _resultSetConcurrency are both null, but not if one or the other is null.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.