You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/26 09:59:07 UTC

[GitHub] [flink] zentol opened a new pull request #11221: [FLINK-16287][es][build] Remove Log4j2 relocation

zentol opened a new pull request #11221: [FLINK-16287][es][build] Remove Log4j2 relocation
URL: https://github.com/apache/flink/pull/11221
 
 
   Log4j2 is no longer bundled in the jar since it is now bundled in flink-dist. The relocation is hence unnecessary and currently breaks the connector.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11221: [FLINK-16287][es][build] Remove Log4j2 relocation

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11221: [FLINK-16287][es][build] Remove Log4j2 relocation
URL: https://github.com/apache/flink/pull/11221#issuecomment-591349243
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "84cf12be7db244dcf2b874376dc77803069d867d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "84cf12be7db244dcf2b874376dc77803069d867d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 84cf12be7db244dcf2b874376dc77803069d867d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11221: [FLINK-16287][es][build] Remove Log4j2 relocation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11221: [FLINK-16287][es][build] Remove Log4j2 relocation
URL: https://github.com/apache/flink/pull/11221#issuecomment-591349243
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "84cf12be7db244dcf2b874376dc77803069d867d",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150625023",
       "triggerID" : "84cf12be7db244dcf2b874376dc77803069d867d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 84cf12be7db244dcf2b874376dc77803069d867d Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/150625023) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] zentol merged pull request #11221: [FLINK-16287][es][build] Remove Log4j2 relocation

Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11221: [FLINK-16287][es][build] Remove Log4j2 relocation
URL: https://github.com/apache/flink/pull/11221
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11221: [FLINK-16287][es][build] Remove Log4j2 relocation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11221: [FLINK-16287][es][build] Remove Log4j2 relocation
URL: https://github.com/apache/flink/pull/11221#issuecomment-591349243
 
 
   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "84cf12be7db244dcf2b874376dc77803069d867d",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/flink-ci/flink/builds/150625023",
       "triggerID" : "84cf12be7db244dcf2b874376dc77803069d867d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 84cf12be7db244dcf2b874376dc77803069d867d Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/150625023) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11221: [FLINK-16287][es][build] Remove Log4j2 relocation

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11221: [FLINK-16287][es][build] Remove Log4j2 relocation
URL: https://github.com/apache/flink/pull/11221#issuecomment-591342932
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 84cf12be7db244dcf2b874376dc77803069d867d (Fri Feb 28 21:48:09 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11221: [FLINK-16287][es][build] Remove Log4j2 relocation

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11221: [FLINK-16287][es][build] Remove Log4j2 relocation
URL: https://github.com/apache/flink/pull/11221#issuecomment-591342932
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 84cf12be7db244dcf2b874376dc77803069d867d (Wed Feb 26 10:03:30 UTC 2020)
   
   **Warnings:**
    * **1 pom.xml files were touched**: Check for build and licensing issues.
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services