[GitHub] [spark] HyukjinKwon commented on a change in pull request #34786: [SPARK-37508][SQL] Update expression desc of `CONTAINS()` string function

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #34786:
URL: https://github.com/apache/spark/pull/34786#discussion_r761549343



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala
##########
@@ -467,8 +467,8 @@ abstract class StringPredicate extends BinaryExpression
  */
 @ExpressionDescription(
   usage = """
-    _FUNC_(expr1, expr2) - Returns a boolean value if expr2 is found inside expr1.
-    Returns NULL if either input expression is NULL.
+    _FUNC_(expr1, expr2) - Returns a BOOLEAN. The value is True if right is found inside left.

Review comment:
       I think using the words expr1 and expr2 is fine as that's shown in the documentation together. BOOLEAN -> boolean is unnecessary. Let's change `Otherwise, returns False.` alone




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org