You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "frankvicky (via GitHub)" <gi...@apache.org> on 2024/09/04 06:30:53 UTC
[PR] KAFKA-16027: Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
frankvicky opened a new pull request, #17083:
URL: https://github.com/apache/kafka/pull/17083
JIRA: [KAFKA-16207](https://issues.apache.org/jira/browse/KAFKA-16027)
> MetadataTest#testUpdatePartitionLeadership is extremely long. I think it is pretty close to the 160 line method limit - I tried to modfity it but it would hit the limit when i tried to break things into separated lines.
The test also contains two tests, so it is best to split it into two separate tests.
We should also move this to ConsumerMetadata.java
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16027: Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah commented on PR #17083:
URL: https://github.com/apache/kafka/pull/17083#issuecomment-2349592295
@frankvicky can you update this PR with trunk?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16027: Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
Posted by "mumrah (via GitHub)" <gi...@apache.org>.
mumrah merged PR #17083:
URL: https://github.com/apache/kafka/pull/17083
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16027: Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #17083:
URL: https://github.com/apache/kafka/pull/17083#issuecomment-2350783594
Hi @mumrah
Thanks for taking look, I have rebased this branch on to trunk. 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-16027: Refactor MetadataTest#testUpdatePartitionLeadership [kafka]
Posted by "frankvicky (via GitHub)" <gi...@apache.org>.
frankvicky commented on PR #17083:
URL: https://github.com/apache/kafka/pull/17083#issuecomment-2351600734
Hi @mumrah
Very appreciate your review 🙇🏼
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org