You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/04/19 20:54:56 UTC

Re: Review Request: Removed the hostname:port slave map from the Master.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10534/
-----------------------------------------------------------

(Updated April 19, 2013, 6:54 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Vinod + changed the set from SlaveId to UPID.


Summary (updated)
-----------------

Removed the hostname:port slave map from the Master.


Description
-------

This simplifies the master state.


Diffs (updated)
-----

  src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed 
  src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 
  src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c 
  src/webui/master/static/controllers.js 0f9573b3e325e4ca9ff9ea1467c1815ea16c0fa1 
  src/webui/master/static/home.html 847d1b687f1d5a6f11e60b81741d4e22104eddf8 

Diff: https://reviews.apache.org/r/10534/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Removed the hostname:port slave map from the Master.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10534/#review19908
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On April 24, 2013, 11:55 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10534/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 11:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This simplifies the master state.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed 
>   src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 
>   src/master/master.cpp c3b26b136a529eee34e9cdf9700176c232f6e436 
>   src/webui/master/static/controllers.js 0f9573b3e325e4ca9ff9ea1467c1815ea16c0fa1 
>   src/webui/master/static/home.html 847d1b687f1d5a6f11e60b81741d4e22104eddf8 
> 
> Diff: https://reviews.apache.org/r/10534/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Re: Review Request: Removed the hostname:port slave map from the Master.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10534/
-----------------------------------------------------------

(Updated April 30, 2013, 1:30 a.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebased off trunk.


Description
-------

This simplifies the master state.


Diffs (updated)
-----

  src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed 
  src/master/master.hpp 4a8aaee5a9970c0dd5cb022f04e48fb308241e20 
  src/master/master.cpp ff2f9546b3e5c885da0a5986606beaca57ba4d5c 
  src/webui/master/static/controllers.js 0f9573b3e325e4ca9ff9ea1467c1815ea16c0fa1 
  src/webui/master/static/home.html 847d1b687f1d5a6f11e60b81741d4e22104eddf8 

Diff: https://reviews.apache.org/r/10534/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Removed the hostname:port slave map from the Master.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10534/
-----------------------------------------------------------

(Updated April 24, 2013, 11:55 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebased.


Description
-------

This simplifies the master state.


Diffs (updated)
-----

  src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed 
  src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 
  src/master/master.cpp c3b26b136a529eee34e9cdf9700176c232f6e436 
  src/webui/master/static/controllers.js 0f9573b3e325e4ca9ff9ea1467c1815ea16c0fa1 
  src/webui/master/static/home.html 847d1b687f1d5a6f11e60b81741d4e22104eddf8 

Diff: https://reviews.apache.org/r/10534/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Removed the hostname:port slave map from the Master.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10534/
-----------------------------------------------------------

(Updated April 19, 2013, 8:57 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Rebased. Will be holding off on committing these until we can be confident that the new semantics are safe in the face of ZK disconnections.

Spoke with Vinod and we may need to consider having the master shutdown unknown slaves that send messages to it.


Description
-------

This simplifies the master state.


Diffs (updated)
-----

  src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed 
  src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 
  src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c 
  src/webui/master/static/controllers.js 0f9573b3e325e4ca9ff9ea1467c1815ea16c0fa1 
  src/webui/master/static/home.html 847d1b687f1d5a6f11e60b81741d4e22104eddf8 

Diff: https://reviews.apache.org/r/10534/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Re: Review Request: Removed the hostname:port slave map from the Master.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10534/#review19470
-----------------------------------------------------------

Ship it!



src/master/master.cpp
<https://reviews.apache.org/r/10534/#comment40219>

    thank you



src/master/master.cpp
<https://reviews.apache.org/r/10534/#comment40220>

    ty


- Vinod Kone


On April 19, 2013, 6:54 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10534/
> -----------------------------------------------------------
> 
> (Updated April 19, 2013, 6:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> This simplifies the master state.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 71b04f01f45ee73d9c246f469e1368223903abed 
>   src/master/master.hpp 9776a7cb8448e41e5d52288e3c637737cee15a08 
>   src/master/master.cpp 5b0e8c03c516f9fc8bb729c21e876bdde89baf9c 
>   src/webui/master/static/controllers.js 0f9573b3e325e4ca9ff9ea1467c1815ea16c0fa1 
>   src/webui/master/static/home.html 847d1b687f1d5a6f11e60b81741d4e22104eddf8 
> 
> Diff: https://reviews.apache.org/r/10534/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>