You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/10 02:32:43 UTC
[GitHub] [pulsar] MarvinCai opened a new pull request #8494: [AdminCli] Add ability to examine specific message by position relative to earliest or latest message.
MarvinCai opened a new pull request #8494:
URL: https://github.com/apache/pulsar/pull/8494
Fixes #5126
### Motivation
Add ability to examine specific message by position relative to earliest or latest message.
So we can easily debug with topic without need to creating subscription or fetching message by getting (legerId:entryId) for that message first.
### Modifications
Add command to get specific message from a topic with relative position.
Exposed asyncReadEntry, getFirstPosition, getPositionAfterN and getNumberOfEntries in PersistentTopic.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change added tests and can be verified as follows:
Added unit test.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API: no
- The schema: no
- The default values of configurations: no
- The wire protocol: no
- The rest endpoints: no
- The admin cli options: yes
- Anything that affects deployment: no
### Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? JavaDocs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #8494: [AdminCli] Add ability to examine specific message by position relative to earliest or latest message.
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #8494:
URL: https://github.com/apache/pulsar/pull/8494#issuecomment-724457957
@zymap Would you please also take a look at this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #8494: [AdminCli] Add ability to examine specific message by position relative to earliest or latest message.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #8494:
URL: https://github.com/apache/pulsar/pull/8494#issuecomment-724936178
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on a change in pull request #8494: [AdminCli] Add ability to examine specific message by position relative to earliest or latest message.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on a change in pull request #8494:
URL: https://github.com/apache/pulsar/pull/8494#discussion_r520748481
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##########
@@ -568,4 +568,42 @@ public void testGetLastMessageId() throws Exception {
Assert.assertTrue(admin.topics().getLastMessageId(topicName) instanceof MessageIdImpl);
}
+
+ @Test()
Review comment:
updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on a change in pull request #8494: [AdminCli] Add ability to examine specific message by position relative to earliest or latest message.
Posted by GitBox <gi...@apache.org>.
jiazhai commented on a change in pull request #8494:
URL: https://github.com/apache/pulsar/pull/8494#discussion_r520292341
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java
##########
@@ -568,4 +568,42 @@ public void testGetLastMessageId() throws Exception {
Assert.assertTrue(admin.topics().getLastMessageId(topicName) instanceof MessageIdImpl);
}
+
+ @Test()
Review comment:
turn `@Test()` into `@Test` if no parameter will add to it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #8494: [AdminCli] Add ability to examine specific message by position relative to earliest or latest message.
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #8494:
URL: https://github.com/apache/pulsar/pull/8494#issuecomment-724913095
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8494: [AdminCli] Add ability to examine specific message by position relative to earliest or latest message.
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8494:
URL: https://github.com/apache/pulsar/pull/8494
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org