You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/08 15:37:11 UTC

[GitHub] [arrow] rtpsw commented on a diff in pull request #14041: ARROW-17610: [C++] Support additional source types in SourceNode

rtpsw commented on code in PR #14041:
URL: https://github.com/apache/arrow/pull/14041#discussion_r966123088


##########
cpp/src/arrow/compute/exec/options.h:
##########
@@ -77,6 +77,34 @@ class ARROW_EXPORT TableSourceNodeOptions : public ExecNodeOptions {
   int64_t max_batch_size;
 };
 
+/// \brief An extended Source node which accepts a schema
+///
+/// ItMaker is a maker of an iterator of tabular data.

Review Comment:
   My (hopefully not wrong) understanding is that options should have value semantics, so that they could be safely copied or passed multiple times as an argument. A factory preserves this semantics whereas an iterator doesn't, because it is stateful.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org