You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2016/04/04 20:16:23 UTC
Review Request 45694: Remove deprecated executor argument
'-announcer-enable'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45694/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Bugs: AURORA-1606
https://issues.apache.org/jira/browse/AURORA-1606
Repository: aurora
Description
-------
Also did a slight shuffle of release notes, 2 items shouldn't have been in the deprecations/removals section.
Diffs
-----
RELEASE-NOTES.md 4eebc9df16c7222fe2c40df2237f77c5d4e76e3a
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c4eda41f816a72327870d23a3de559c61dc03028
Diff: https://reviews.apache.org/r/45694/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 45694: Remove deprecated executor argument
'-announcer-enable'
Posted by Stephan Erb <se...@apache.org>.
> On April 4, 2016, 8:38 p.m., Stephan Erb wrote:
> > RELEASE-NOTES.md, line 24
> > <https://reviews.apache.org/r/45694/diff/1/?file=1324738#file1324738line24>
> >
> > Seems like we missed to add that to the scheduler command line documentation. Would you mind adding it there?
>
> Bill Farner wrote:
> Sure thing. I noticed that tabs are converted to spaces on master. Unless you disagree, i've undone that to make the doc a direct copy-paste.
Yeah totaly fine. Must have been my editor or something like that.
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45694/#review126894
-----------------------------------------------------------
On April 4, 2016, 8:48 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45694/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 8:48 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1606
> https://issues.apache.org/jira/browse/AURORA-1606
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also did a slight shuffle of release notes, 2 items shouldn't have been in the deprecations/removals section.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 6fc3afeb5a9e2f2c2ba944fbc6d611d3494eb779
> docs/reference/scheduler-configuration.md 9945531aeb53db7387e3b030521be94a66a0c9f0
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c4eda41f816a72327870d23a3de559c61dc03028
>
> Diff: https://reviews.apache.org/r/45694/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45694: Remove deprecated executor argument
'-announcer-enable'
Posted by Bill Farner <wf...@apache.org>.
> On April 4, 2016, 11:38 a.m., Stephan Erb wrote:
> > RELEASE-NOTES.md, line 24
> > <https://reviews.apache.org/r/45694/diff/1/?file=1324738#file1324738line24>
> >
> > Seems like we missed to add that to the scheduler command line documentation. Would you mind adding it there?
Sure thing. I noticed that tabs are converted to spaces on master. Unless you disagree, i've undone that to make the doc a direct copy-paste.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45694/#review126894
-----------------------------------------------------------
On April 4, 2016, 11:16 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45694/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 11:16 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1606
> https://issues.apache.org/jira/browse/AURORA-1606
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also did a slight shuffle of release notes, 2 items shouldn't have been in the deprecations/removals section.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4eebc9df16c7222fe2c40df2237f77c5d4e76e3a
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c4eda41f816a72327870d23a3de559c61dc03028
>
> Diff: https://reviews.apache.org/r/45694/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45694: Remove deprecated executor argument
'-announcer-enable'
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45694/#review126894
-----------------------------------------------------------
RELEASE-NOTES.md (line 24)
<https://reviews.apache.org/r/45694/#comment189981>
Seems like we missed to add that to the scheduler command line documentation. Would you mind adding it there?
- Stephan Erb
On April 4, 2016, 8:16 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45694/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 8:16 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1606
> https://issues.apache.org/jira/browse/AURORA-1606
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also did a slight shuffle of release notes, 2 items shouldn't have been in the deprecations/removals section.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4eebc9df16c7222fe2c40df2237f77c5d4e76e3a
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c4eda41f816a72327870d23a3de559c61dc03028
>
> Diff: https://reviews.apache.org/r/45694/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45694: Remove deprecated executor argument
'-announcer-enable'
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45694/#review126901
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On April 4, 2016, 8:48 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45694/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 8:48 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1606
> https://issues.apache.org/jira/browse/AURORA-1606
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also did a slight shuffle of release notes, 2 items shouldn't have been in the deprecations/removals section.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 6fc3afeb5a9e2f2c2ba944fbc6d611d3494eb779
> docs/reference/scheduler-configuration.md 9945531aeb53db7387e3b030521be94a66a0c9f0
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c4eda41f816a72327870d23a3de559c61dc03028
>
> Diff: https://reviews.apache.org/r/45694/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45694: Remove deprecated executor argument
'-announcer-enable'
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45694/
-----------------------------------------------------------
(Updated April 4, 2016, 11:48 a.m.)
Review request for Aurora and Zameer Manji.
Changes
-------
Rebase + update scheduler arg docs.
Bugs: AURORA-1606
https://issues.apache.org/jira/browse/AURORA-1606
Repository: aurora
Description
-------
Also did a slight shuffle of release notes, 2 items shouldn't have been in the deprecations/removals section.
Diffs (updated)
-----
RELEASE-NOTES.md 6fc3afeb5a9e2f2c2ba944fbc6d611d3494eb779
docs/reference/scheduler-configuration.md 9945531aeb53db7387e3b030521be94a66a0c9f0
src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c4eda41f816a72327870d23a3de559c61dc03028
Diff: https://reviews.apache.org/r/45694/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 45694: Remove deprecated executor argument
'-announcer-enable'
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45694/#review126891
-----------------------------------------------------------
This patch does not apply cleanly against master (f6be7b6), do you need to rebase?
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 4, 2016, 6:16 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45694/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 6:16 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1606
> https://issues.apache.org/jira/browse/AURORA-1606
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also did a slight shuffle of release notes, 2 items shouldn't have been in the deprecations/removals section.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4eebc9df16c7222fe2c40df2237f77c5d4e76e3a
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c4eda41f816a72327870d23a3de559c61dc03028
>
> Diff: https://reviews.apache.org/r/45694/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 45694: Remove deprecated executor argument
'-announcer-enable'
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45694/#review126889
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On April 4, 2016, 11:16 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45694/
> -----------------------------------------------------------
>
> (Updated April 4, 2016, 11:16 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1606
> https://issues.apache.org/jira/browse/AURORA-1606
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Also did a slight shuffle of release notes, 2 items shouldn't have been in the deprecations/removals section.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md 4eebc9df16c7222fe2c40df2237f77c5d4e76e3a
> src/main/python/apache/aurora/executor/bin/thermos_executor_main.py c4eda41f816a72327870d23a3de559c61dc03028
>
> Diff: https://reviews.apache.org/r/45694/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>