[jira] [Comment Edited] (FLINK-29509) Set correct subtaskId during recovery of committables

["Krzysztof Chmielewski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-29509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613888#comment-17613888 ] 

Krzysztof Chmielewski edited comment on FLINK-29509 at 10/7/22 4:29 PM:
------------------------------------------------------------------------

PR ready for review :)
[https://github.com/apache/flink/pull/20979]


was (Author: kristoffsc):
PR:
https://github.com/apache/flink/pull/20979

> Set correct subtaskId during recovery of committables
> -----------------------------------------------------
>
>                 Key: FLINK-29509
>                 URL: https://issues.apache.org/jira/browse/FLINK-29509
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Common
>    Affects Versions: 1.17.0, 1.15.2, 1.16.1
>            Reporter: Fabian Paul
>            Assignee: Krzysztof Chmielewski
>            Priority: Critical
>
> When we recover the `CheckpointCommittableManager` we ignore the subtaskId it is recovered on. [https://github.com/apache/flink/blob/d191bda7e63a2c12416cba56090e5cd75426079b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/committables/CheckpointCommittableManagerImpl.java#L58]
> This becomes a problem when a sink uses a post-commit topology because multiple committer operators might forward committable summaries coming from the same subtaskId.
>  
> It should be possible to use the subtaskId already present in the `CommittableCollector` when creating the `CheckpointCommittableManager`s.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)