You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Alexander Denissov <ad...@apache.org> on 2016/01/08 23:58:54 UTC
Review Request 42091: Expose pxf-public.classpath and pxf-profiles.xml
configs for PXF service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42091/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Oleksandr Diachenko, and Sumit Mohanty.
Bugs: AMBARI-14579
https://issues.apache.org/jira/browse/AMBARI-14579
Repository: ambari
Description
-------
Expose pxf-public.classpath and pxf-profiles.xml configs for PXF service
Diffs
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml PRE-CREATION
ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-public-classpath.xml PRE-CREATION
ambari-server/src/main/resources/common-services/PXF/3.0.0/metainfo.xml 0548ab5
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py caae9bf
Diff: https://reviews.apache.org/r/42091/diff/
Testing
-------
Tested manually.
Thanks,
Alexander Denissov
Re: Review Request 42091: Expose pxf-public.classpath and
pxf-profiles.xml configs for PXF service
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42091/#review113604
-----------------------------------------------------------
Ship it!
Ship It!
- Matt
On Jan. 8, 2016, 2:58 p.m., Alexander Denissov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42091/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 2:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14579
> https://issues.apache.org/jira/browse/AMBARI-14579
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Expose pxf-public.classpath and pxf-profiles.xml configs for PXF service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-public-classpath.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/metainfo.xml 0548ab5
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py caae9bf
>
> Diff: https://reviews.apache.org/r/42091/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
>
> Thanks,
>
> Alexander Denissov
>
>
Re: Review Request 42091: Expose pxf-public.classpath and
pxf-profiles.xml configs for PXF service
Posted by bhuvnesh chaudhary <bc...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42091/#review113563
-----------------------------------------------------------
Ship it!
- bhuvnesh chaudhary
On Jan. 8, 2016, 10:58 p.m., Alexander Denissov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42091/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 10:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14579
> https://issues.apache.org/jira/browse/AMBARI-14579
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Expose pxf-public.classpath and pxf-profiles.xml configs for PXF service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-public-classpath.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/metainfo.xml 0548ab5
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py caae9bf
>
> Diff: https://reviews.apache.org/r/42091/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
>
> Thanks,
>
> Alexander Denissov
>
>
Re: Review Request 42091: Expose pxf-public.classpath and
pxf-profiles.xml configs for PXF service
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42091/#review113605
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py (line 103)
<https://reviews.apache.org/r/42091/#comment174367>
Will have to update unit test for these: https://github.com/apache/ambari/blob/trunk/ambari-server/src/test/python/stacks/2.3/PXF/test_pxf.py#L35-#L52
- Matt
On Jan. 8, 2016, 2:58 p.m., Alexander Denissov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42091/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 2:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14579
> https://issues.apache.org/jira/browse/AMBARI-14579
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Expose pxf-public.classpath and pxf-profiles.xml configs for PXF service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-public-classpath.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/metainfo.xml 0548ab5
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py caae9bf
>
> Diff: https://reviews.apache.org/r/42091/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
>
> Thanks,
>
> Alexander Denissov
>
>
Re: Review Request 42091: Expose pxf-public.classpath and
pxf-profiles.xml configs for PXF service
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42091/#review113858
-----------------------------------------------------------
Ship it!
Ship It!
- Matt
On Jan. 11, 2016, 12:24 p.m., Alexander Denissov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42091/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 12:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Oleksandr Diachenko, and Sumit Mohanty.
>
>
> Bugs: AMBARI-14579
> https://issues.apache.org/jira/browse/AMBARI-14579
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Expose pxf-public.classpath and pxf-profiles.xml configs for PXF service
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-public-classpath.xml PRE-CREATION
> ambari-server/src/main/resources/common-services/PXF/3.0.0/metainfo.xml 0548ab5
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py caae9bf
> ambari-server/src/test/python/stacks/2.3/PXF/test_pxf.py 3d803c5
> ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json 310d9ef
>
> Diff: https://reviews.apache.org/r/42091/diff/
>
>
> Testing
> -------
>
> Tested manually.
>
>
> Thanks,
>
> Alexander Denissov
>
>
Re: Review Request 42091: Expose pxf-public.classpath and
pxf-profiles.xml configs for PXF service
Posted by Alexander Denissov <ad...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42091/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 8:24 p.m.)
Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Oleksandr Diachenko, and Sumit Mohanty.
Changes
-------
updated unit tests
Bugs: AMBARI-14579
https://issues.apache.org/jira/browse/AMBARI-14579
Repository: ambari
Description
-------
Expose pxf-public.classpath and pxf-profiles.xml configs for PXF service
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-profiles.xml PRE-CREATION
ambari-server/src/main/resources/common-services/PXF/3.0.0/configuration/pxf-public-classpath.xml PRE-CREATION
ambari-server/src/main/resources/common-services/PXF/3.0.0/metainfo.xml 0548ab5
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf.py caae9bf
ambari-server/src/test/python/stacks/2.3/PXF/test_pxf.py 3d803c5
ambari-server/src/test/python/stacks/2.3/configs/pxf_default.json 310d9ef
Diff: https://reviews.apache.org/r/42091/diff/
Testing
-------
Tested manually.
Thanks,
Alexander Denissov