(sedona-db) branch main updated: fix(rust/sedona-raster-functions): Update creation of a repeated string view with more efficient method (#903)

[pa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

paleolimbot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/sedona-db.git


The following commit(s) were added to refs/heads/main by this push:
     new ccea9351a fix(rust/sedona-raster-functions): Update creation of a repeated string view with more efficient method (#903)
ccea9351a is described below

commit ccea9351a91c1c200b74c4b33a0f3ef2e9185ea3
Author: Dewey Dunnington <de...@dunnington.ca>
AuthorDate: Fri Jun 5 11:19:19 2026 -0500

    fix(rust/sedona-raster-functions): Update creation of a repeated string view with more efficient method (#903)
---
 rust/sedona-raster-functions/src/rs_setsrid.rs | 27 +++++++++++++++++---------
 1 file changed, 18 insertions(+), 9 deletions(-)

diff --git a/rust/sedona-raster-functions/src/rs_setsrid.rs b/rust/sedona-raster-functions/src/rs_setsrid.rs
index 2ff6134e4..9848825b8 100644
--- a/rust/sedona-raster-functions/src/rs_setsrid.rs
+++ b/rust/sedona-raster-functions/src/rs_setsrid.rs
@@ -17,6 +17,7 @@
 
 use std::sync::Arc;
 
+use arrow_array::builder::StringViewBuilder;
 use arrow_array::{Array, ArrayRef, StringViewArray, StructArray};
 use arrow_buffer::NullBuffer;
 use arrow_schema::DataType;
@@ -24,6 +25,7 @@ use datafusion_common::cast::{as_int64_array, as_string_view_array};
 use datafusion_common::error::Result;
 use datafusion_common::{exec_err, DataFusionError, ScalarValue};
 use datafusion_expr::{ColumnarValue, Volatility};
+use sedona_common::{sedona_internal_datafusion_err, sedona_internal_err};
 use sedona_expr::scalar_udf::{SedonaScalarKernel, SedonaScalarUDF};
 use sedona_geometry::transform::CrsEngine;
 use sedona_schema::crs::{CachedCrsNormalization, CachedSRIDToCrs};
@@ -168,13 +170,11 @@ fn replace_raster_crs(
                 .as_any()
                 .downcast_ref::<StructArray>()
                 .ok_or_else(|| {
-                    datafusion_common::DataFusionError::Internal(
-                        "Expected StructArray for raster data".to_string(),
-                    )
+                    sedona_internal_datafusion_err!("Expected StructArray for raster data")
                 })?;
 
             let num_rows = raster_struct.len();
-            let new_crs: ArrayRef = broadcast_string_view(crs_array, num_rows);
+            let new_crs: ArrayRef = broadcast_string_view(crs_array, num_rows)?;
             let new_struct = swap_crs_column(raster_struct, new_crs)?;
 
             let input_nulls = input_nulls.map(|nulls| {
@@ -224,16 +224,25 @@ fn replace_raster_crs(
 ///
 /// If the array already has the target length, it is returned as-is (clone of Arc).
 /// Otherwise the array must have length 1, and its single value is repeated.
-fn broadcast_string_view(array: &StringViewArray, len: usize) -> ArrayRef {
+fn broadcast_string_view(array: &StringViewArray, len: usize) -> Result<ArrayRef> {
     if array.len() == len {
-        return Arc::new(array.clone());
+        return Ok(Arc::new(array.clone()));
     }
-    debug_assert_eq!(array.len(), 1);
+
+    if array.len() != 1 {
+        return sedona_internal_err!(
+            "Expected array of length {len} or 1 but got {}",
+            array.len()
+        );
+    }
+
     if array.is_null(0) {
-        Arc::new(StringViewArray::new_null(len))
+        Ok(Arc::new(StringViewArray::new_null(len)))
     } else {
         let value = array.value(0);
-        Arc::new(std::iter::repeat_n(Some(value), len).collect::<StringViewArray>())
+        let mut builder = StringViewBuilder::with_capacity(len);
+        builder.try_append_value_n(value, len)?;
+        Ok(Arc::new(builder.finish()))
     }
 }