You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/09/29 09:10:34 UTC

[GitHub] [dubbo-go] venusDo opened a new pull request #782: fix:dynamic router is constructed when the notified address is 'route…

venusDo opened a new pull request #782:
URL: https://github.com/apache/dubbo-go/pull/782


   as title 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #782: fix:dynamic router is constructed when the notified address is 'route…

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #782:
URL: https://github.com/apache/dubbo-go/pull/782#issuecomment-705947696


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=h1) Report
   > Merging [#782](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6c0535ce6236f135e7a1fadc71539ce0d8c249f?el=desc) will **increase** coverage by `0.07%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/782/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #782      +/-   ##
   ===========================================
   + Coverage    59.80%   59.87%   +0.07%     
   ===========================================
     Files          259      259              
     Lines        12737    12739       +2     
   ===========================================
   + Hits          7617     7628      +11     
   + Misses        4166     4161       -5     
   + Partials       954      950       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.09% <100.00%> (+3.08%)` | :arrow_up: |
   | [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
   | [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `70.19% <0.00%> (+2.88%)` | :arrow_up: |
   | [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `75.75% <0.00%> (+3.03%)` | :arrow_up: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `51.16% <0.00%> (+4.65%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=footer). Last update [c6c0535...18ae342](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks closed pull request #782: fix:dynamic router is constructed when the notified address is 'route…

Posted by GitBox <gi...@apache.org>.
AlexStocks closed pull request #782:
URL: https://github.com/apache/dubbo-go/pull/782


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on pull request #782: fix:dynamic router is constructed when the notified address is 'route…

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #782:
URL: https://github.com/apache/dubbo-go/pull/782#issuecomment-705947696


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=h1) Report
   > Merging [#782](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6c0535ce6236f135e7a1fadc71539ce0d8c249f?el=desc) will **increase** coverage by `0.07%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/782/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #782      +/-   ##
   ===========================================
   + Coverage    59.80%   59.87%   +0.07%     
   ===========================================
     Files          259      259              
     Lines        12737    12739       +2     
   ===========================================
   + Hits          7617     7628      +11     
   + Misses        4166     4161       -5     
   + Partials       954      950       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.09% <100.00%> (+3.08%)` | :arrow_up: |
   | [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
   | [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `70.19% <0.00%> (+2.88%)` | :arrow_up: |
   | [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `75.75% <0.00%> (+3.03%)` | :arrow_up: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `51.16% <0.00%> (+4.65%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=footer). Last update [c6c0535...b66d371](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on pull request #782: fix:dynamic router is constructed when the notified address is 'route…

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #782:
URL: https://github.com/apache/dubbo-go/pull/782#issuecomment-705947696


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=h1) Report
   > Merging [#782](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6c0535ce6236f135e7a1fadc71539ce0d8c249f?el=desc) will **increase** coverage by `0.07%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/782/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #782      +/-   ##
   ===========================================
   + Coverage    59.80%   59.87%   +0.07%     
   ===========================================
     Files          259      259              
     Lines        12737    12739       +2     
   ===========================================
   + Hits          7617     7628      +11     
   + Misses        4166     4161       -5     
   + Partials       954      950       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.09% <100.00%> (+3.08%)` | :arrow_up: |
   | [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
   | [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `70.19% <0.00%> (+2.88%)` | :arrow_up: |
   | [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `75.75% <0.00%> (+3.03%)` | :arrow_up: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `51.16% <0.00%> (+4.65%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=footer). Last update [c6c0535...b66d371](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io edited a comment on pull request #782: fix:dynamic router is constructed when the notified address is 'route…

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #782:
URL: https://github.com/apache/dubbo-go/pull/782#issuecomment-705947696


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=h1) Report
   > Merging [#782](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/c6c0535ce6236f135e7a1fadc71539ce0d8c249f?el=desc) will **increase** coverage by `0.07%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/782/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL)](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #782      +/-   ##
   ===========================================
   + Coverage    59.80%   59.87%   +0.07%     
   ===========================================
     Files          259      259              
     Lines        12737    12739       +2     
   ===========================================
   + Hits          7617     7628      +11     
   + Misses        4166     4161       -5     
   + Partials       954      950       -4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [registry/directory/directory.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZGlyZWN0b3J5L2RpcmVjdG9yeS5nbw==) | `77.09% <100.00%> (+3.08%)` | :arrow_up: |
   | [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `59.34% <0.00%> (-4.07%)` | :arrow_down: |
   | [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
   | [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `79.34% <0.00%> (+2.17%)` | :arrow_up: |
   | [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `70.19% <0.00%> (+2.88%)` | :arrow_up: |
   | [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `75.75% <0.00%> (+3.03%)` | :arrow_up: |
   | [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/782/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `51.16% <0.00%> (+4.65%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=footer). Last update [c6c0535...18ae342](https://codecov.io/gh/apache/dubbo-go/pull/782?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org