You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/03/27 17:12:09 UTC

[GitHub] [httpcomponents-core] Marcono1234 opened a new pull request #275: Fix TextUtils.toHexString having incorrect result for negative values

Marcono1234 opened a new pull request #275:
URL: https://github.com/apache/httpcomponents-core/pull/275


   The check `b < 16` was faulty and would have added a '0' for negative values.
   E.g. for `(byte) 0xFF` the result would have been `"0ff"`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] ok2c commented on pull request #275: Fix TextUtils.toHexString having incorrect result for negative values

Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #275:
URL: https://github.com/apache/httpcomponents-core/pull/275#issuecomment-808875872


   @Marcono1234 Ported to `5.1.x` as well. Many thanks for contributing this fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] ok2c merged pull request #275: Fix TextUtils.toHexString having incorrect result for negative values

Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #275:
URL: https://github.com/apache/httpcomponents-core/pull/275


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org