You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/08/07 19:39:23 UTC

[GitHub] [helix] narendly commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

narendly commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue
URL: https://github.com/apache/helix/pull/376#discussion_r311727727
 
 

 ##########
 File path: helix-rest/src/main/java/org/apache/helix/rest/server/service/InstanceService.java
 ##########
 @@ -90,8 +89,22 @@ InstanceInfo getInstanceInfo(String clusterId, String instanceName,
    * Get the current instance stoppable checks
    * @param clusterId The cluster id
    * @param instanceName The instance name
+   * @param jsonContent The json payloads from client side
    * @return An instance of {@link StoppableCheck} easily convertible to JSON
+   * @throws IOException in case of network failure
    */
   StoppableCheck getInstanceStoppableCheck(String clusterId, String instanceName,
       String jsonContent) throws IOException;
+
+  /**
+   * Batch get StoppableCheck results for a list of instances in one cluster
+   *
 
 Review comment:
   Doesn't helix-style.xml remove extra lines in block comments? I am not sure if this PR has been formatted with helix-style.xml, although it says so in the PR description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org