[GitHub] [kafka] cmccabe commented on a diff in pull request #13438: KAFKA-14835: Create ControllerServerMetricsPublisher

["cmccabe (via GitHub)" <gi...@apache.org>]

cmccabe commented on code in PR #13438:
URL: https://github.com/apache/kafka/pull/13438#discussion_r1146899679


##########
core/src/main/scala/kafka/server/ControllerServer.scala:
##########
@@ -366,6 +376,8 @@ class ControllerServer(
       // Ensure that we're not the Raft leader prior to shutting down our socket server, for a
       // smoother transition.
       sharedServer.ensureNotRaftLeader()
+      metadataPublishers.forEach(p => sharedServer.loader.removeAndClosePublisher(p).get())

Review Comment:
   I would like to do this eventually, but we don't have any shutdown timeout currently. We would have to add something like that in order to use it here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org