Re: [OT] NSIS and the need for signing callbacks

[Christopher Schultz <ch...@christopherschultz.net>]

Mark,

On 3/11/25 8:09 AM, Mark Thomas wrote:
> On 11/03/2025 11:24, Mark Thomas wrote:
> 
> <snip/>
> 
>> File Uninstall.exe
>>
>> line fails claiming it can' t open ".\Uninstall.exe"
>>
>> but that file is created a few steps earlier and is present when I 
>> check the file system.
>>
>> Still looking...
> 
> It is JSign again.
> 
> If I switch back to JSign 6.0 the build starts working. Based on what we 
> have seen previously, it looks JSign is retaining a reference to the 
> Uninstall.exe that it has just injected the signature into and that is 
> preventing NSIS from copying the file.
> 
> Because Ant uses JSign in process, it is particularly susceptible to any 
> issues with not closing files.

It looks like most subclasses of Signable have a no-op save() method, 
but if those were written to close all resources, this might not be a 
problem anymore.

Looking at SignerHelper, Signable, and the PEFile implementation, it 
looks like that file SHOULD be closed.

-chris


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org