[GitHub] [knox] risdenk commented on a change in pull request #75: KNOX-1828 Fix Websocket Message Size

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #75: KNOX-1828 Fix Websocket Message Size
URL: https://github.com/apache/knox/pull/75#discussion_r266429519
 
 

 ##########
 File path: gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java
 ##########
 @@ -87,6 +87,8 @@ public void onWebSocketConnect(final Session frontEndSession) {
      * plumbing takes place
      */
     container = ContainerProvider.getWebSocketContainer();
+    container.setDefaultMaxBinaryMessageBufferSize(Integer.MAX_VALUE);
+    container.setDefaultMaxTextMessageBufferSize(Integer.MAX_VALUE);
 
 Review comment:
   Would be great to use the configs for this instead of hard coding to `Integer.MAX_VALUE`. I haven't looked to see how easy it is to access the gateway config here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services