You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/29 04:33:44 UTC
[GitHub] [iotdb] MiniSho opened a new pull request, #8240: [To rel/1.0] [IOTDB-5047] Fix iotdb.jmx.port missing from data-env.sh
MiniSho opened a new pull request, #8240:
URL: https://github.com/apache/iotdb/pull/8240
Add JMX_PORT to system properties in data-env.sh/bat
ConfigNode:
DataNode:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #8240: [To rel/1.0] [IOTDB-5047] Fix iotdb.jmx.port missing from data-env.sh
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on PR #8240:
URL: https://github.com/apache/iotdb/pull/8240#issuecomment-1330215914
Besides, the StartChecker is incorrect as even when we start a confignode, it also says ".....datanode-env.sh"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #8240: [To rel/1.0] [IOTDB-5047] Fix iotdb.jmx.port missing from data-env.sh
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on PR #8240:
URL: https://github.com/apache/iotdb/pull/8240#issuecomment-1330215224
A simple solution:
Change IOTDB_JMX_PORT from "iotdb.jmx.port" to "com.sun.management.jmxremote.port"
then there is no need to modify the scripts.
```
- public static final String IOTDB_JMX_PORT = "iotdb.jmx.port";
+ public static final String IOTDB_JMX_PORT = "com.sun.management.jmxremote.port";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #8240: [To rel/1.0] [IOTDB-5047] Fix iotdb.jmx.port missing from data-env.sh
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on PR #8240:
URL: https://github.com/apache/iotdb/pull/8240#issuecomment-1330213701
Only when JMX_LOCAL=false, the port can be set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] Beyyes merged pull request #8240: [To rel/1.0] [IOTDB-5047] Fix iotdb.jmx.port missing from data-env.sh
Posted by GitBox <gi...@apache.org>.
Beyyes merged PR #8240:
URL: https://github.com/apache/iotdb/pull/8240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jixuan1989 commented on pull request #8240: [To rel/1.0] [IOTDB-5047] Fix iotdb.jmx.port missing from data-env.sh
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on PR #8240:
URL: https://github.com/apache/iotdb/pull/8240#issuecomment-1330217517
> A simple solution:
>
> Change IOTDB_JMX_PORT from "iotdb.jmx.port" to "com.sun.management.jmxremote.port" then there is no need to modify the scripts.
>
> ```
> - public static final String IOTDB_JMX_PORT = "iotdb.jmx.port";
> + public static final String IOTDB_JMX_PORT = "com.sun.management.jmxremote.port";
> ```
Better solution:
set `JMX_LOCAL` as a variable to IoTDB (modify the -env scripts). Then in StartChecker.java, you should check whether the user wants to monitor JMX locally or open its remote port. In this way, we can give users more clear tips.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org