You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/06 12:37:46 UTC
[GitHub] [airflow] kaxil opened a new issue #16833: Chart: Add docs on using custom pod-template
kaxil opened a new issue #16833:
URL: https://github.com/apache/airflow/issues/16833
Currently, we allow users to use their own `podTemplate` yaml using the `podTemplate` key in `values.yaml`. Some users have passed the name of the file in `podTemplate` instead of YAML string.
We should have a dedicated page on how a user could do that and add an example in `values.yaml` file itself.
https://airflow.apache.org/docs/helm-chart/stable/parameters-ref.html
https://github.com/apache/airflow/blob/81fde5844de37e90917deaaff9576914cb2637ee/chart/values.yaml#L1123-L1125
https://github.com/apache/airflow/blob/81fde5844de37e90917deaaff9576914cb2637ee/chart/templates/configmaps/configmap.yaml#L59-L65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
dstandish commented on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-961545278
sure think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
kaxil closed issue #16833:
URL: https://github.com/apache/airflow/issues/16833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
dstandish commented on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-961545278
sure think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-896377516
Cool, thanks. For resources you can use `workers.resources`. `workers.extraContainers` isn't automatically added to k8s workers, but it probably should be (with a warning that you are on your own for stopping the sidecar so Airflow can continue its shutdown process).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish edited a comment on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
dstandish edited a comment on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-961545278
sure thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
dstandish commented on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-961545278
sure think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-961543614
Is this still pending, if yes can you take this over @dstandish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gmsantos commented on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
gmsantos commented on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-895818962
Does make sense to support helm templates in `podTemplate`? As of today, there is no easy way to customize the`files/pod-template-file.kubernetes-helm-yaml` content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] gmsantos commented on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
gmsantos commented on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-896294720
Something I'm missing is to define a sidecar container or specific resources requests and limits for Airflow tasks on top of the generated pod template file.
Giving an extra context, internally we allow teams to deploy data platform instances in a K8s cluster and the Airflow chart is the main component of it. One goal is to abstract Airflow base configuration and other components in a custom chart with recommended default values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-961543614
Is this still pending, if yes can you take this over @dstandish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-898697562
@gmsantos, in the next release `podTemplate` can be templated and `workers.extraContainers` will be added to k8s workers automatically. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-896259214
Yeah, passing `podTemplate` through `tpl` makes sense to me.
What is your use case for modifying the template though? Most of the "normal" scenarios I can think of off the top of my head are pretty much already covered. I'd love to hear it so we can consider how best to support whatever it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish edited a comment on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
dstandish edited a comment on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-961545278
sure thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish edited a comment on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
dstandish edited a comment on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-961545278
sure thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #16833: Chart: Add docs on using custom pod-template
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #16833:
URL: https://github.com/apache/airflow/issues/16833#issuecomment-961543614
Is this still pending, if yes can you take this over @dstandish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org