[Impala-ASF-CR] IMPALA-11916: Replace base::IsAarch64 with constant

["Quanlong Huang (Code Review)" <ge...@cloudera.org>]

Hello Fang-Yu Rao, Wenzhe Zhou, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19492

to look at the new patch set (#2).

Change subject: IMPALA-11916: Replace base::IsAarch64 with constant
......................................................................

IMPALA-11916: Replace base::IsAarch64 with constant

base::IsAarch64() returns true for Aarch64 platforms and returns false
for x86 platforms. It shows up in a perf test and consumes some
percents. Note that it's used in the hot path of hash computation. This
patch replaces this method with a constant, IS_AARCH64. Defines the
constant in cpu-info.h since the original place is in a file ported from
gutil.

Test:
 - Redo the perf test and don't see base::IsAarch64 anymore.

Change-Id: Id6d62de63a0cb7b94244a1d4f8dcc6b2e65b6d9c
---
M be/src/codegen/llvm-codegen-test.cc
M be/src/codegen/llvm-codegen.cc
M be/src/gutil/sysinfo.cc
M be/src/gutil/sysinfo.h
M be/src/util/bit-util-test.cc
M be/src/util/cpu-info.h
M be/src/util/hash-util.h
7 files changed, 19 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/92/19492/2
-- 
To view, visit http://gerrit.cloudera.org:8080/19492
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id6d62de63a0cb7b94244a1d4f8dcc6b2e65b6d9c
Gerrit-Change-Number: 19492
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>