[GitHub] [iceberg] holdenk commented on a change in pull request #2761: Add an implemention of STARTS_WITH for Python API.

[GitBox <gi...@apache.org>]

holdenk commented on a change in pull request #2761:
URL: https://github.com/apache/iceberg/pull/2761#discussion_r661889045



##########
File path: python/iceberg/api/expressions/expressions.py
##########
@@ -106,6 +106,15 @@ def equal(name, value):
     def not_equal(name, value):
         return UnboundPredicate(Operation.NOT_EQ, Expressions.ref(name), value)
 
+    # In Python we use "startswith", to match the direct conversion & the pythonic impl do both.

Review comment:
       Yeah so good point on that being confusing.
   
   startswith is to match the Python impl and starts_with is to match the "normal" conversion of camel case to snake case that is present in PyIceberg. I'll update the comment, thanks :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org