You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/09 19:42:43 UTC

[GitHub] [flink] StephanEwen commented on pull request #12529: [FLINK-17800][roksdb] Ensure total order seek to avoid user misuse

StephanEwen commented on pull request #12529:
URL: https://github.com/apache/flink/pull/12529#issuecomment-641530162


   Thanks for looking into this issue.
   
   The testing looks like it executes all tests an additional time with the "optimizeForPointLookup" option set. That seems pretty brute-force and adds a lot of testing time. I am also not sure it is relevant for many cases. For example, restore operations should not be affected by the user-defined column family options, so running all incremental checkpointing tests for "optimizeForPointLookup" seems not very targeted.
   
   Could we instead add two tests that specifically test the option for MapState and other states affected by that option?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org