[GitHub] [rocketmq] vongosling commented on a change in pull request #1368: [ISSUE #1369]Polish the MQVersion setting ways and make sure it can be automatically set

[GitBox <gi...@apache.org>]

vongosling commented on a change in pull request #1368: [ISSUE #1369]Polish the MQVersion setting ways and make sure it can be automatically set
URL: https://github.com/apache/rocketmq/pull/1368#discussion_r311379695
 
 

 ##########
 File path: acl/src/main/java/org/apache/rocketmq/acl/common/AclClientRPCHook.java
 ##########
 @@ -44,8 +46,9 @@ public void doBeforeRequest(String remoteAddr, RemotingCommand request) {
         String signature = AclUtils.calSignature(total, sessionCredentials.getSecretKey());
         request.addExtField(SIGNATURE, signature);
         request.addExtField(ACCESS_KEY, sessionCredentials.getAccessKey());
-        
-        // The SecurityToken value is unneccessary,user can choose this one.
+        request.addExtField(SOURCE, MQVersion.currentSource);
 
 Review comment:
   Does it work if I disable the ACL?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services