You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ian Babrou <ib...@gmail.com> on 2016/01/04 04:43:59 UTC

Re: Review Request 40546: Fixed framework CPU counters on slave page.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40546/
-----------------------------------------------------------

(Updated Jan. 4, 2016, 3:43 a.m.)


Review request for mesos, Jan Schlicht and Till Toenshoff.


Changes
-------

Assinged reviewer and shepherd, fixed summary to adhere to our style.


Summary (updated)
-----------------

Fixed framework CPU counters on slave page.


Bugs: MESOS-3972
    https://issues.apache.org/jira/browse/MESOS-3972


Repository: mesos


Description (updated)
-------

see summary


Diffs
-----

  src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 

Diff: https://reviews.apache.org/r/40546/diff/


Testing
-------


Thanks,

Ian Babrou


Re: Review Request 40546: Fixed framework CPU counters on slave page.

Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40546/#review112533
-----------------------------------------------------------

Ship it!


- Jan Schlicht


On Jan. 4, 2016, 4:43 a.m., Ian Babrou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40546/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 4:43 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-3972
>     https://issues.apache.org/jira/browse/MESOS-3972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 
> 
> Diff: https://reviews.apache.org/r/40546/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>


Re: Review Request 40546: Fixed framework CPU counters on slave page.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40546/#review113084
-----------------------------------------------------------


I will go ahead and discard this review as it is no longer needed - https://reviews.apache.org/r/41927/ fixed the problem in a preferred way.

Thanks for your submission, Ian!

- Till Toenshoff


On Jan. 4, 2016, 3:43 a.m., Ian Babrou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40546/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos, Jan Schlicht and Till Toenshoff.
> 
> 
> Bugs: MESOS-3972
>     https://issues.apache.org/jira/browse/MESOS-3972
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> see summary
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/slave.html a1446bce827944609faf10f72e788f33d275d6f9 
> 
> Diff: https://reviews.apache.org/r/40546/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>