[CForms] Fixing samples, some questions arise

[hepabolu <he...@gmail.com>]

Guys,

I'm currently patching the CForms samples with the patch I entered in 
Bugzilla just before the 2.1.7 release.
(http://issues.apache.org/bugzilla/show_bug.cgi?id=34077)

Some questions arose:

1. the XHR_carselector sample is broken. I think it should either be 
fixed (seems to be difficult) or removed entirely. Since the current 
AJAX implementation is better, I propose to remove it.

2. Small bug: the Datasource chooser defaults to "SQL". Switching to 
"empty" doesn't work, first switching to "file" does work and subsequent 
switch to "empty" works. I have not looked into fixing the bug, but I 
propose to default the chooser to "empty" rather than "SQL". I'll leave 
the "<fd:initial-value>" line in comments for documentation.

3. Just committed two samples (in BRANCH) where I added a header with a 
short description of the sample's purpose. WDYT? If there are no major 
objections, I'll add this kind of headers to all Forms samples.

And I'll update TRUNK as well.

Bye, Helma

Re: [CForms] Fixing samples, some questions arise

[Jorg Heymans <jh...@domek.be>]

hepabolu wrote:

>> good idea. Maybe you could graphically separate the short description a
>> bit more somehow so its more clear where the description ends and where
>> the actual sample starts.
> 
> 
> :-) Have you actually LOOKED at the sample runtime? I've used the same
> CSS class as the group headers in the overview page of the samples, i.e.
>  blue background with dark blue bottom border (and the lower left corner
> rounded if you use Firefox).
> 
> Looks different enough to me. ;-)
> 

I must have expressed myself wrong. What i meant to say was is that
maybe a little bit more space or a thin line between the sample
description (ie the text ending with "to see how this is done" on
localhost:8888/samples/blocks/forms/carselector ) and the actual sample
output could improve readability. It was the first thing that came to my
mind after looking at the page - ignore it.


I realize now that you were only referring to the "AJAX Sample" part you
added - which is ofcourse adequately separated :-)


Jorg

Re: [CForms] Fixing samples, some questions arise

[hepabolu <he...@gmail.com>]

Jorg Heymans wrote:

> Yes remove it. Its description even uses the word "historical", which in
> software development terms usually means broken :-)

True, so I'll remove it.

>>3. Just committed two samples (in BRANCH) where I added a header with a
>>short description of the sample's purpose. WDYT? If there are no major
>>objections, I'll add this kind of headers to all Forms samples.
> 
> good idea. Maybe you could graphically separate the short description a
> bit more somehow so its more clear where the description ends and where
> the actual sample starts.

:-) Have you actually LOOKED at the sample runtime? I've used the same 
CSS class as the group headers in the overview page of the samples, i.e. 
  blue background with dark blue bottom border (and the lower left 
corner rounded if you use Firefox).

Looks different enough to me. ;-)

Bye, Helma

Re: [CForms] Fixing samples, some questions arise

[Jorg Heymans <jh...@domek.be>]

hepabolu wrote:
> 
> Some questions arose:
> 
> 1. the XHR_carselector sample is broken. I think it should either be
> fixed (seems to be difficult) or removed entirely. Since the current
> AJAX implementation is better, I propose to remove it.

Yes remove it. Its description even uses the word "historical", which in
software development terms usually means broken :-)

> 
> 3. Just committed two samples (in BRANCH) where I added a header with a
> short description of the sample's purpose. WDYT? If there are no major
> objections, I'll add this kind of headers to all Forms samples.
> 

good idea. Maybe you could graphically separate the short description a
bit more somehow so its more clear where the description ends and where
the actual sample starts.


Jorg

Re: [CForms] Fixing samples, some questions arise

[Ugo Cei <ug...@apache.org>]

Il giorno 07/set/05, alle 14:22, hepabolu ha scritto:

> 1. the XHR_carselector sample is broken. I think it should either be 
> fixed (seems to be difficult) or removed entirely. Since the current 
> AJAX implementation is better, I propose to remove it.

+1.

	Ugo

-- 
Ugo Cei
Tech Blog: http://agylen.com/
Open Source Zone: http://oszone.org/
Wine & Food Blog: http://www.divinocibo.it/