You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/24 13:44:39 UTC

[GitHub] [incubator-devlake] warren830 opened a new issue, #3179: [Feature][Github] pull_request_commits do not have merge_commit

warren830 opened a new issue, #3179:
URL: https://github.com/apache/incubator-devlake/issues/3179

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-devlake/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   pull_request_commits do not have merge_commit
   
   ### Use case
   
   I suggest to add merge_commit to pr_commits
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 commented on issue #3179: [Feature][Github/Gitlab] pull_request_commits do not have merge_commit

Posted by GitBox <gi...@apache.org>.
warren830 commented on issue #3179:
URL: https://github.com/apache/incubator-devlake/issues/3179#issuecomment-1257733653

   > The merge commit sha is stored into `pr.merge_commit_sha`, I don't think storing it to `pr_commits` is the right call.
   
   Get, will colse this issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 closed issue #3179: [Feature][Github/Gitlab] pull_request_commits do not have merge_commit

Posted by GitBox <gi...@apache.org>.
warren830 closed issue #3179: [Feature][Github/Gitlab] pull_request_commits do not have merge_commit
URL: https://github.com/apache/incubator-devlake/issues/3179


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh commented on issue #3179: [Feature][Github/Gitlab] pull_request_commits do not have merge_commit

Posted by GitBox <gi...@apache.org>.
klesh commented on issue #3179:
URL: https://github.com/apache/incubator-devlake/issues/3179#issuecomment-1257728165

   The merge commit sha is stored into `pr.merge_commit_sha`, I don't think storing it to `pr_commits` is the right call.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org