You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/01/28 03:27:05 UTC
[GitHub] [incubator-brpc] hcoona opened a new issue #1688: Is there any particular reason for vendoring snappy?
hcoona opened a new issue #1688:
URL: https://github.com/apache/incubator-brpc/issues/1688
I notice that butil vendor snappy under https://github.com/apache/incubator-brpc/tree/1.0.0/src/butil/third_party/rapidjson
bRPC strongly depends on LevelDB, and LevelDB almost always compiles with snappy in production. Is there any particular reason using a vendor snappy instead of depending on a common snappy library?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] hcoona commented on issue #1688: Is there any particular reason for vendoring snappy?
Posted by GitBox <gi...@apache.org>.
hcoona commented on issue #1688:
URL: https://github.com/apache/incubator-brpc/issues/1688#issuecomment-1024010270
Many projects provide 2 ways for linking external dependencies:
1. link against user-provided dependencies
2. link against bundled dependencies
I think the vendors are good for would not cause conflict while bad for users controlling the dependencies.
It would be appreciate if there was any flag to control it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1688: Is there any particular reason for vendoring snappy?
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on issue #1688:
URL: https://github.com/apache/incubator-brpc/issues/1688#issuecomment-1024048873
If you need that flag you can submit a PR, that's welcome. : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] wwbmmm commented on issue #1688: Is there any particular reason for vendoring snappy?
Posted by GitBox <gi...@apache.org>.
wwbmmm commented on issue #1688:
URL: https://github.com/apache/incubator-brpc/issues/1688#issuecomment-1024007368
I guess it's because snappy's codebase is small and doesn't require frequent upgrades.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org