You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/21 09:46:04 UTC

[GitHub] [rocketmq] YangJodie opened a new issue, #4858: Add consumer type check when call consumeMessageDirectly

YangJodie opened a new issue, #4858:
URL: https://github.com/apache/rocketmq/issues/4858

   **Description：**
   consumeMessageDirectly method should check the consumer type because this method only works in push consumer type.
   
   **Detailed changes:**
   
   1. Add check for QueryMsgByUniqueKeySubCommand and QueryMsgByIdSubCommand.
   2. Add type checking when call the org.apache.rocketmq.client.impl.factory.MQClientInstance#consumeMessageDirectly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhanhui commented on issue #4858: Add consumer type check when call consumeMessageDirectly

Posted by GitBox <gi...@apache.org>.
lizhanhui commented on issue #4858:
URL: https://github.com/apache/rocketmq/issues/4858#issuecomment-1221706786

   @YangJodie Will it be better to have this check applied on the broker side now that brokers already have client type information through heartbeats?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] duhenglucky closed issue #4858: Add consumer type check when call consumeMessageDirectly

Posted by GitBox <gi...@apache.org>.
duhenglucky closed issue #4858: Add consumer type check when call consumeMessageDirectly
URL: https://github.com/apache/rocketmq/issues/4858


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org