You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by Otis Gospodnetic <ot...@yahoo.com> on 2007/04/30 05:24:18 UTC

On Closing JIRA issues

Hi,

I *think* the practise is to just resolve issues as Fixed when their patches are committed.  I believe we can then close them after the release containing that fix has been released.  That said, I know I rarely actually close JIRA issues after releases over in Lucene-java.

Otis
 . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
Simpy -- http://www.simpy.com/  -  Tag  -  Search  -  Share

----- Original Message ----
From: Ryan McKinley (JIRA) <ji...@apache.org>
To: solr-dev@lucene.apache.org
Sent: Sunday, April 29, 2007 8:42:15 PM
Subject: [jira] Closed: (SOLR-181) Support for "Required" field Property


     [ https://issues.apache.org/jira/browse/SOLR-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ryan McKinley closed SOLR-181.
------------------------------

    Resolution: Fixed

commited

> Support for "Required" field Property
> -------------------------------------
>
>                 Key: SOLR-181
>                 URL: https://issues.apache.org/jira/browse/SOLR-181
>             Project: Solr
>          Issue Type: Improvement
>          Components: update
>            Reporter: Greg Ludington
>         Assigned To: Ryan McKinley
>            Priority: Minor
>         Attachments: solr-181-required-fields.patch, solr-181-required-fields.patch
>
>
> In certain situations, it can be helpful to require every document in your index has a value for a given field.  While ideally the indexing client(s) should be responsible enough to add all necessary fields, this patch allows it to be enforced in the Solr schema, by adding a required property to a field entry.  For example, with this in the schema:
>    <field name="name" type="nametext" indexed="true" stored="true" required="true"/>
> A request to index a document without a name field will result in this response:
> <result status="1">org.apache.solr.core.SolrException: missing required fields: name 
> (and then, of course, the stack trace)
> </result>
> The meat of this patch is that DocumentBuilder.getDoc() throws a SolrException if not all required fields have values; this may not work well as is with SOLR-139, Support updateable/modifiable documents, and may have to be changed depending on that issue's final disposition.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.





Re: On Closing JIRA issues

Posted by Chris Hostetter <ho...@fucit.org>.
: hymmm, i only did one action: "Resolve Issue" -> "Fixed" and that sets
: the status to "Closed" with a resolution "Fixed"
:
: Is there something i'm missing?

in the Workflow area there are usually two links "Resolve Issue" and
"Close Issue" ... both of which take you to nearly identicle screens for
stating the "Resolution", fix version, asignee, and a comment ... i'm
guessing you just hit "Close Issue' inadvertantly.



-Hoss


Re: On Closing JIRA issues

Posted by Ryan McKinley <ry...@gmail.com>.
Otis Gospodnetic wrote:
> Hi,
> 
> I *think* the practise is to just resolve issues as Fixed when their patches are committed.  I believe we can then close them after the release containing that fix has been released.  That said, I know I rarely actually close JIRA issues after releases over in Lucene-java.
> 

hymmm, i only did one action: "Resolve Issue" -> "Fixed" and that sets 
the status to "Closed" with a resolution "Fixed"

Is there something i'm missing?