BEAM-3415 JUnit5 support

[Emils Solmanis <em...@uswitch.com>]

Hi all,

The JUnit5 (BEAM-3415 <https://issues.apache.org/jira/browse/BEAM-3415>)
has been open for quite some time, and it's been of interest to me and our
organisation as well, since Beam is the only thing keeping JUnit4 around
for us

I took a stab at it and made a PR (#14272
<https://github.com/apache/beam/pull/14272>), I'd like to think it's clean
and doesn't interfere with much else, the only outside observable change
would be opening up the TestPipeline interface a bit (protected constructor
to allow inheritance). The build is green minus 1 Jenkins job that timed
out and I can't restart.

The original ticket claims it's "a lot of work", but it didn't end up being
that, I suspect JUnit5 has evolved a bit in the 2-3 years since the
original issue.

The OWNERS file on the 'core' module also only lists Luke as the sole
maintainer, I've tagged him in the PR, but have no idea what the timeline
expectations are. It's been 4 days now, if we're saying the turnaround is a
couple weeks it's not urgent, but I also appreciate the OWNERS files
sometimes get stale, so is it the case that @lukecwik is the only
maintainer?

Best,
Emil

Re: BEAM-3415 JUnit5 support

[Boyuan Zhang <bo...@google.com>]

Hi Emils,

Thanks for your contribution. Luke is on vacation till June. I'm adding
some java folks into your PR, who might be able to help review your PR as
well.

On Mon, Mar 22, 2021 at 9:17 AM Emils Solmanis <em...@uswitch.com>
wrote:

> Hi all,
>
> The JUnit5 (BEAM-3415 <https://issues.apache.org/jira/browse/BEAM-3415>)
> has been open for quite some time, and it's been of interest to me and our
> organisation as well, since Beam is the only thing keeping JUnit4 around
> for us
>
> I took a stab at it and made a PR (#14272
> <https://github.com/apache/beam/pull/14272>), I'd like to think it's
> clean and doesn't interfere with much else, the only outside observable
> change would be opening up the TestPipeline interface a bit (protected
> constructor to allow inheritance). The build is green minus 1 Jenkins job
> that timed out and I can't restart.
>
> The original ticket claims it's "a lot of work", but it didn't end up
> being that, I suspect JUnit5 has evolved a bit in the 2-3 years since the
> original issue.
>
> The OWNERS file on the 'core' module also only lists Luke as the sole
> maintainer, I've tagged him in the PR, but have no idea what the timeline
> expectations are. It's been 4 days now, if we're saying the turnaround is a
> couple weeks it's not urgent, but I also appreciate the OWNERS files
> sometimes get stale, so is it the case that @lukecwik is the only
> maintainer?
>
> Best,
> Emil
>