You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Adam Wight (JIRA)" <ji...@apache.org> on 2008/05/28 23:10:45 UTC

[jira] Created: (SHINDIG-313) made GadgetRenderingTask subclassable

made GadgetRenderingTask subclassable
-------------------------------------

                 Key: SHINDIG-313
                 URL: https://issues.apache.org/jira/browse/SHINDIG-313
             Project: Shindig
          Issue Type: Improvement
          Components: Gadget Rendering Server (Java)
            Reporter: Adam Wight
            Priority: Minor


Making private members of GadgetRenderingTask "protected" allows us to reuse this code to create new rendering servlets.  In particular, we have written an "html-inline" servlet to substitute for the deprecated html-inline Content type.  Inline rendering for trusted gadgets enables full interaction with the DOM.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Created: (SHINDIG-313) made GadgetRenderingTask subclassable

Posted by John Hjelmstad <fa...@google.com>.
Hi Adam:

Can you tell me a little more about your desire to support html-inline?
Until now we've explicitly chosen not to support them since by definition
they aren't portable: an inlined gadget (that actually interacts with the
surrounding DOM rather than using gadgets.rpc-mitigated APIs) is explicitly
tied to a single container.

That works directly against a key promise of gadgets, to be Write Once Run
Anywhere For The Web (tm).

Even when using gadgets as an application extension mechanism for a specific
site, inlining places significant restrictions on the container.

Sorry to subject you to an inquisition :)

--John

On Wed, May 28, 2008 at 2:10 PM, Adam Wight (JIRA) <ji...@apache.org> wrote:
made GadgetRenderingTask subclassable
-------------------------------------

                Key: SHINDIG-313
                URL: https://issues.apache.org/jira/browse/SHINDIG-313
            Project: Shindig
         Issue Type: Improvement
         Components: Gadget Rendering Server (Java)
           Reporter: Adam Wight
           Priority: Minor


Making private members of GadgetRenderingTask "protected" allows us to reuse
this code to create new rendering servlets.  In particular, we have written
an "html-inline" servlet to substitute for the deprecated html-inline
Content type.  Inline rendering for trusted gadgets enables full interaction
with the DOM.

--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (SHINDIG-313) made GadgetRenderingTask subclassable

Posted by "Kevin Brown (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601518#action_12601518 ] 

Kevin Brown commented on SHINDIG-313:
-------------------------------------

This isn't really the ideal way to handle inline gadgets. Instead, you should probably call into GadgetServer directly (or use the metadata service if you're not already java based), and then just print the output. This guarantees that you're able to control formatting and control flow.

GadgetRenderingTask is already doing way more work than it should be (content filters don't belong in there, for instance). This work would be placed directly into GadgetRenderingServlet if not for the limitations on servlet initialization.

> made GadgetRenderingTask subclassable
> -------------------------------------
>
>                 Key: SHINDIG-313
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-313
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (Java)
>            Reporter: Adam Wight
>            Priority: Minor
>         Attachments: rendering.patch
>
>
> Making private members of GadgetRenderingTask "protected" allows us to reuse this code to create new rendering servlets.  In particular, we have written an "html-inline" servlet to substitute for the deprecated html-inline Content type.  Inline rendering for trusted gadgets enables full interaction with the DOM.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-313) made GadgetRenderingTask subclassable

Posted by "Adam Wight (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Wight updated SHINDIG-313:
-------------------------------

    Attachment: rendering.patch

We have html-inline servlet code available if the Shindig community wants this feature.

> made GadgetRenderingTask subclassable
> -------------------------------------
>
>                 Key: SHINDIG-313
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-313
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Gadget Rendering Server (Java)
>            Reporter: Adam Wight
>            Priority: Minor
>         Attachments: rendering.patch
>
>
> Making private members of GadgetRenderingTask "protected" allows us to reuse this code to create new rendering servlets.  In particular, we have written an "html-inline" servlet to substitute for the deprecated html-inline Content type.  Inline rendering for trusted gadgets enables full interaction with the DOM.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.