You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by li...@apache.org on 2026/06/27 15:05:21 UTC

(hbase) branch master updated: HBASE-30241 Addendum Fix flaky testClonedTableWithLinksSurvivesSourceDeletion (#8420)

This is an automated email from the ASF dual-hosted git repository.

liuxiaocs7 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/hbase.git


The following commit(s) were added to refs/heads/master by this push:
     new 6385a4dbd94 HBASE-30241 Addendum Fix flaky testClonedTableWithLinksSurvivesSourceDeletion (#8420)
6385a4dbd94 is described below

commit 6385a4dbd94419caba0984eb70d6eec9fa109445
Author: Xiao Liu <li...@apache.org>
AuthorDate: Sat Jun 27 23:05:13 2026 +0800

    HBASE-30241 Addendum Fix flaky testClonedTableWithLinksSurvivesSourceDeletion (#8420)
    
    Signed-off-by: Peng Lu <lu...@apache.org>
---
 ...eSnapshotFromClientAfterSplittingRegionWithLinksTestBase.java | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/CloneSnapshotFromClientAfterSplittingRegionWithLinksTestBase.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/CloneSnapshotFromClientAfterSplittingRegionWithLinksTestBase.java
index 88ce13954c7..4874a999a2f 100644
--- a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/CloneSnapshotFromClientAfterSplittingRegionWithLinksTestBase.java
+++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/CloneSnapshotFromClientAfterSplittingRegionWithLinksTestBase.java
@@ -121,12 +121,13 @@ public class CloneSnapshotFromClientAfterSplittingRegionWithLinksTestBase
     // so the snapshot contains only HFileLinks and no Reference files.
     int numRegions = admin.getRegions(tableName).size();
     admin.split(tableName, SPLIT_KEY);
-    await().atMost(Duration.ofSeconds(60)).untilAsserted(
+    await().atMost(Duration.ofSeconds(30)).untilAsserted(
       () -> assertEquals(numRegions + numReplicas, admin.getRegions(tableName).size()));
 
-    // Guard: the split must have produced only HFileLinks (no Reference files) for the daughters,
-    // otherwise this test would silently degrade into the Reference case.
-    assertDaughtersHaveOnlyLinks();
+    // Guard: the split must have produced only HFileLinks (no Reference files) for the daughters.
+    // admin.getRegions() can report the daughters (from meta) before the region servers have opened
+    // them and loaded their store files, so retry until the links are actually online.
+    await().atMost(Duration.ofSeconds(30)).untilAsserted(this::assertDaughtersHaveOnlyLinks);
 
     // Take a snapshot and clone it.
     admin.snapshot(snapshotName, tableName);