You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Andrea Del Bene <an...@gmail.com> on 2018/01/03 21:43:30 UTC
WICKET-6514 and FeedbackPanel
Hi,
as a result of WICKET-6514 now FeedbackPanel doesn't show anymore
session messages. I'm not sure if this was intentional, but I think
FeedbackPanel shouldn't change its behavior. Should we modify
FeedbackPanel to restore the original behavior?
PS: I've noted this change with FeedbackPanel because now a wicketstuff
test fails
(org.wicketstuff.minis.component.DefaultInvisibleFeedbackPanelTest.testVisibility).
Andrea.
Re: WICKET-6514 and FeedbackPanel
Posted by Martin Makundi <ma...@koodaripalvelut.com>.
What is the reasoning behind the "design" of not showing session level
feedback messages?
**
Martin
2018-01-04 4:41 GMT+02:00 Maxim Solodovnik <so...@gmail.com>:
> I thought this API break was "by design"
> Maybe this can be documented instead?
>
> WBR, Maxim
> (from mobile, sorry for the typos)
>
> On Thu, Jan 4, 2018, 05:22 Martijn Dashorst <ma...@gmail.com>
> wrote:
>
> > On Wed, Jan 3, 2018 at 10:43 PM, Andrea Del Bene <an...@gmail.com>
> > wrote:
> > > Hi,
> > >
> > > as a result of WICKET-6514 now FeedbackPanel doesn't show anymore
> session
> > > messages. I'm not sure if this was intentional, but I think
> > FeedbackPanel
> > > shouldn't change its behavior. Should we modify FeedbackPanel to
> restore
> > the
> > > original behavior?
> >
> > Yes. There are countless applications depending on this type of
> > messaging. This is a regression.
> >
> > Martijn
> >
>
Re: WICKET-6514 and FeedbackPanel
Posted by Martijn Dashorst <ma...@gmail.com>.
Op do 4 jan. 2018 om 03:42 schreef Maxim Solodovnik <so...@gmail.com>
> I thought this API break was "by design"
> Maybe this can be documented instead?
>
FeedbackPanel should use the constructor with session messages enabled.
That is the API break, not the collector change.
Martijn
> WBR, Maxim
> (from mobile, sorry for the typos)
>
> On Thu, Jan 4, 2018, 05:22 Martijn Dashorst <ma...@gmail.com>
> wrote:
>
> > On Wed, Jan 3, 2018 at 10:43 PM, Andrea Del Bene <an...@gmail.com>
> > wrote:
> > > Hi,
> > >
> > > as a result of WICKET-6514 now FeedbackPanel doesn't show anymore
> session
> > > messages. I'm not sure if this was intentional, but I think
> > FeedbackPanel
> > > shouldn't change its behavior. Should we modify FeedbackPanel to
> restore
> > the
> > > original behavior?
> >
> > Yes. There are countless applications depending on this type of
> > messaging. This is a regression.
> >
> > Martijn
> >
>
--
Become a Wicket expert, learn from the best: http://wicketinaction.com
Re: WICKET-6514 and FeedbackPanel
Posted by Maxim Solodovnik <so...@gmail.com>.
I thought this API break was "by design"
Maybe this can be documented instead?
WBR, Maxim
(from mobile, sorry for the typos)
On Thu, Jan 4, 2018, 05:22 Martijn Dashorst <ma...@gmail.com>
wrote:
> On Wed, Jan 3, 2018 at 10:43 PM, Andrea Del Bene <an...@gmail.com>
> wrote:
> > Hi,
> >
> > as a result of WICKET-6514 now FeedbackPanel doesn't show anymore session
> > messages. I'm not sure if this was intentional, but I think
> FeedbackPanel
> > shouldn't change its behavior. Should we modify FeedbackPanel to restore
> the
> > original behavior?
>
> Yes. There are countless applications depending on this type of
> messaging. This is a regression.
>
> Martijn
>
Re: WICKET-6514 and FeedbackPanel
Posted by Martin Grigorov <mg...@apache.org>.
On Thu, Jan 4, 2018 at 5:17 PM, Andrea Del Bene <an...@gmail.com>
wrote:
> I couldn't sleep because I've read about Meltdown and Spectre bugs :-).
> All joking aside, I've added a test case for FeedbackPanel and session
> messages. To restore the original behavior I've changed
> FeedbackMessagesModel adding an includeSession flag which is true by
> default.
>
> WDYT?
>
LGTM!
Thank you!
>
> On 04/01/2018 01:40, Martijn Dashorst wrote:
>
>> GO TO SLEEP YOU FOOL!
>>
>> (I couldn’t sleep due to a storm rattling my solar panels on our roof so
>> I have an excuse. What’s yours?)
>>
>> Martijn
>>
>> Ps HAPPY NEW YEAR!
>>
>> Op 4 jan. 2018 om 01:23 heeft Andrea Del Bene <an...@gmail.com> het
>>> volgende geschreven:
>>>
>>> I can take care of it tomorrow.
>>>
>>>
>>>
>>> On 03/01/2018 23:22, Martijn Dashorst wrote:
>>>>
>>>>> On Wed, Jan 3, 2018 at 10:43 PM, Andrea Del Bene <an...@gmail.com>
>>>>> wrote:
>>>>> Hi,
>>>>>
>>>>> as a result of WICKET-6514 now FeedbackPanel doesn't show anymore
>>>>> session
>>>>> messages. I'm not sure if this was intentional, but I think
>>>>> FeedbackPanel
>>>>> shouldn't change its behavior. Should we modify FeedbackPanel to
>>>>> restore the
>>>>> original behavior?
>>>>>
>>>> Yes. There are countless applications depending on this type of
>>>> messaging. This is a regression.
>>>>
>>>> Martijn
>>>>
>>>
>
Re: WICKET-6514 and FeedbackPanel
Posted by Andrea Del Bene <an...@gmail.com>.
I couldn't sleep because I've read about Meltdown and Spectre bugs :-).
All joking aside, I've added a test case for FeedbackPanel and session
messages. To restore the original behavior I've changed
FeedbackMessagesModel adding an includeSession flag which is true by
default.
WDYT?
On 04/01/2018 01:40, Martijn Dashorst wrote:
> GO TO SLEEP YOU FOOL!
>
> (I couldn’t sleep due to a storm rattling my solar panels on our roof so I have an excuse. What’s yours?)
>
> Martijn
>
> Ps HAPPY NEW YEAR!
>
>> Op 4 jan. 2018 om 01:23 heeft Andrea Del Bene <an...@gmail.com> het volgende geschreven:
>>
>> I can take care of it tomorrow.
>>
>>
>>> On 03/01/2018 23:22, Martijn Dashorst wrote:
>>>> On Wed, Jan 3, 2018 at 10:43 PM, Andrea Del Bene <an...@gmail.com> wrote:
>>>> Hi,
>>>>
>>>> as a result of WICKET-6514 now FeedbackPanel doesn't show anymore session
>>>> messages. I'm not sure if this was intentional, but I think FeedbackPanel
>>>> shouldn't change its behavior. Should we modify FeedbackPanel to restore the
>>>> original behavior?
>>> Yes. There are countless applications depending on this type of
>>> messaging. This is a regression.
>>>
>>> Martijn
Re: WICKET-6514 and FeedbackPanel
Posted by Martijn Dashorst <ma...@gmail.com>.
On Wed, Jan 3, 2018 at 10:43 PM, Andrea Del Bene <an...@gmail.com> wrote:
> Hi,
>
> as a result of WICKET-6514 now FeedbackPanel doesn't show anymore session
> messages. I'm not sure if this was intentional, but I think FeedbackPanel
> shouldn't change its behavior. Should we modify FeedbackPanel to restore the
> original behavior?
Yes. There are countless applications depending on this type of
messaging. This is a regression.
Martijn
Re: WICKET-6514 and FeedbackPanel
Posted by Martin Grigorov <mg...@apache.org>.
Hi,
https://git-wip-us.apache.org/repos/asf?p=wicket.git;a=commitdiff;h=63a3296;hp=db2317bf4c08074277294dbe596af841639513de
Here I have preserved the old behavior in FencedFeedbackPanel and
BaseWicketTester.
No other tests (in Wicket) failed so I thought there is nothing else to
touch.
Please add a new test case or move the one from WicketStuff.
Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov
On Wed, Jan 3, 2018 at 11:43 PM, Andrea Del Bene <an...@gmail.com>
wrote:
> Hi,
>
> as a result of WICKET-6514 now FeedbackPanel doesn't show anymore session
> messages. I'm not sure if this was intentional, but I think FeedbackPanel
> shouldn't change its behavior. Should we modify FeedbackPanel to restore
> the original behavior?
>
> PS: I've noted this change with FeedbackPanel because now a wicketstuff
> test fails (org.wicketstuff.minis.component.DefaultInvisibleFeedbackPan
> elTest.testVisibility).
>
> Andrea.
>
>