You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:36:51 UTC
[GitHub] [incubator-pinot] yupeng9 commented on a change in pull request #6220: Adding BootstrapTable command to allow bootstrapping a table from an example directory
yupeng9 commented on a change in pull request #6220:
URL: https://github.com/apache/incubator-pinot/pull/6220#discussion_r516174216
##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/UpsertQuickStart.java
##########
@@ -48,13 +48,12 @@ public static void main(String[] args)
public void execute()
throws Exception {
File quickstartTmpDir = new File(FileUtils.getTempDirectory(), String.valueOf(System.currentTimeMillis()));
- File configDir = new File(quickstartTmpDir, "configs");
- File dataDir = new File(quickstartTmpDir, "data");
- Preconditions.checkState(configDir.mkdirs());
+ File bootstrapTableDir = new File(quickstartTmpDir, "meetupRsvp");
+ File dataDir = new File(bootstrapTableDir, "data");
Preconditions.checkState(dataDir.mkdirs());
- File schemaFile = new File(configDir, "upsert_meetupRsvp_schema.json");
- File tableConfigFile = new File(configDir, "upsert_meetupRsvp_realtime_table_config.json");
+ File schemaFile = new File(bootstrapTableDir, "meetupRsvp_schema.json");
Review comment:
this change is not right?
##########
File path: pinot-tools/src/main/java/org/apache/pinot/tools/UpsertQuickStart.java
##########
@@ -48,13 +48,12 @@ public static void main(String[] args)
public void execute()
throws Exception {
File quickstartTmpDir = new File(FileUtils.getTempDirectory(), String.valueOf(System.currentTimeMillis()));
- File configDir = new File(quickstartTmpDir, "configs");
- File dataDir = new File(quickstartTmpDir, "data");
- Preconditions.checkState(configDir.mkdirs());
+ File bootstrapTableDir = new File(quickstartTmpDir, "meetupRsvp");
+ File dataDir = new File(bootstrapTableDir, "data");
Preconditions.checkState(dataDir.mkdirs());
- File schemaFile = new File(configDir, "upsert_meetupRsvp_schema.json");
- File tableConfigFile = new File(configDir, "upsert_meetupRsvp_realtime_table_config.json");
+ File schemaFile = new File(bootstrapTableDir, "meetupRsvp_schema.json");
Review comment:
Right. But any reason to rename it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org