[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #149: Add disabled mem control & improve memory efficiency

[GitBox <gi...@apache.org>]

jixuan1989 commented on a change in pull request #149: Add disabled mem control & improve memory efficiency
URL: https://github.com/apache/incubator-iotdb/pull/149#discussion_r277155089
 
 

 ##########
 File path: iotdb/src/main/java/org/apache/iotdb/db/engine/bufferwrite/BufferWriteProcessor.java
 ##########
 @@ -454,38 +485,6 @@ public long getFileSize() {
     return file.length() + memoryUsage();
   }
 
-  /**
-   * Close current TsFile and open a new one for future writes. Block new writes and wait until
-   * current writes finish.
-   */
-  public void rollToNewFile() {
-    // TODO : [MemControl] implement this
-  }
-
-  /**
-   * Check if this TsFile has too big metadata or file. If true, close current file and open a new
-   * one.
-   */
-  private boolean checkSize() {
 
 Review comment:
   why you delete this function... 
   I think this strategy is useful, and we need to consider where to call this method...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services