You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/17 13:36:15 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4343: Decouple SQLStatement.findSegment() and InsertStatement
terrymanu opened a new pull request #4343: Decouple SQLStatement.findSegment() and InsertStatement
URL: https://github.com/apache/incubator-shardingsphere/pull/4343
For #4342.
Changes proposed in this pull request:
- Decouple SQLStatement.findSegment() and InsertStatement.setAssignment
- Decouple SQLStatement.findSegment() and InsertStatement.onDuplicateKeyColumns
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4343: Decouple SQLStatement.findSegment() and InsertStatement
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4343: Decouple SQLStatement.findSegment() and InsertStatement
URL: https://github.com/apache/incubator-shardingsphere/pull/4343#issuecomment-587011499
## Pull Request Test Coverage Report for [Build 1773](https://coveralls.io/builds/28776666)
* **13** of **23** **(56.52%)** changed or added relevant lines in **8** files are covered.
* **13** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.05%**) to **57.627%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/insert/OnDuplicateKeyColumnsExtractor.java](https://coveralls.io/builds/28776666/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Finsert%2FOnDuplicateKeyColumnsExtractor.java#L47) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/InsertStatement.java](https://coveralls.io/builds/28776666/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FInsertStatement.java#L89) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/filler/impl/dml/OnDuplicateKeyColumnsFiller.java](https://coveralls.io/builds/28776666/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Ffiller%2Fimpl%2Fdml%2FOnDuplicateKeyColumnsFiller.java#L32) | 1 | 3 | 33.33%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28776666/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L119) | 0 | 6 | 0.0%
<!-- | **Total:** | **13** | **23** | **56.52%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28776666/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/rule/registry/ParseRuleRegistry.java](https://coveralls.io/builds/28776666/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Frule%2Fregistry%2FParseRuleRegistry.java#L69) | 11 | 59.26% |
<!-- | **Total:** | **13** | | -->
| Totals | [](https://coveralls.io/builds/28776666) |
| :-- | --: |
| Change from base [Build 9600](https://coveralls.io/builds/28775250): | -0.05% |
| Covered Lines: | 11080 |
| Relevant Lines: | 19227 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4343: Decouple SQLStatement.findSegment() and InsertStatement
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4343: Decouple SQLStatement.findSegment() and InsertStatement
URL: https://github.com/apache/incubator-shardingsphere/pull/4343#issuecomment-587011499
## Pull Request Test Coverage Report for [Build 1774](https://coveralls.io/builds/28776697)
* **13** of **23** **(56.52%)** changed or added relevant lines in **8** files are covered.
* **13** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.05%**) to **57.627%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/insert/OnDuplicateKeyColumnsExtractor.java](https://coveralls.io/builds/28776697/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Finsert%2FOnDuplicateKeyColumnsExtractor.java#L47) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/InsertStatement.java](https://coveralls.io/builds/28776697/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FInsertStatement.java#L89) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/filler/impl/dml/OnDuplicateKeyColumnsFiller.java](https://coveralls.io/builds/28776697/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Ffiller%2Fimpl%2Fdml%2FOnDuplicateKeyColumnsFiller.java#L32) | 1 | 3 | 33.33%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/28776697/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L119) | 0 | 6 | 0.0%
<!-- | **Total:** | **13** | **23** | **56.52%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28776697/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/rule/registry/ParseRuleRegistry.java](https://coveralls.io/builds/28776697/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Frule%2Fregistry%2FParseRuleRegistry.java#L69) | 11 | 59.26% |
<!-- | **Total:** | **13** | | -->
| Totals | [](https://coveralls.io/builds/28776697) |
| :-- | --: |
| Change from base [Build 9600](https://coveralls.io/builds/28775250): | -0.05% |
| Covered Lines: | 11080 |
| Relevant Lines: | 19227 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tristaZero merged pull request #4343:
Decouple SQLStatement.findSegment() and InsertStatement
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #4343: Decouple SQLStatement.findSegment() and InsertStatement
URL: https://github.com/apache/incubator-shardingsphere/pull/4343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#4343: Decouple SQLStatement.findSegment() and InsertStatement
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #4343: Decouple SQLStatement.findSegment() and InsertStatement
URL: https://github.com/apache/incubator-shardingsphere/pull/4343#issuecomment-587011499
## Pull Request Test Coverage Report for [Build 9601](https://coveralls.io/builds/28775713)
* **13** of **16** **(81.25%)** changed or added relevant lines in **6** files are covered.
* **11** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.06%**) to **57.625%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/InsertStatement.java](https://coveralls.io/builds/28775713/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FInsertStatement.java#L89) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/filler/impl/dml/OnDuplicateKeyColumnsFiller.java](https://coveralls.io/builds/28775713/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Ffiller%2Fimpl%2Fdml%2FOnDuplicateKeyColumnsFiller.java#L32) | 1 | 3 | 33.33%
<!-- | **Total:** | **13** | **16** | **81.25%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/rule/registry/ParseRuleRegistry.java](https://coveralls.io/builds/28775713/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Frule%2Fregistry%2FParseRuleRegistry.java#L69) | 11 | 59.26% |
<!-- | **Total:** | **11** | | -->
| Totals | [](https://coveralls.io/builds/28775713) |
| :-- | --: |
| Change from base [Build 9600](https://coveralls.io/builds/28775250): | -0.06% |
| Covered Lines: | 11079 |
| Relevant Lines: | 19226 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4343:
Decouple SQLStatement.findSegment() and InsertStatement
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4343: Decouple SQLStatement.findSegment() and InsertStatement
URL: https://github.com/apache/incubator-shardingsphere/pull/4343#issuecomment-587011499
## Pull Request Test Coverage Report for [Build 1772](https://coveralls.io/builds/28775371)
* **13** of **16** **(81.25%)** changed or added relevant lines in **6** files are covered.
* **13** unchanged lines in **2** files lost coverage.
* Overall coverage decreased (**-0.05%**) to **57.63%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/InsertStatement.java](https://coveralls.io/builds/28775371/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FInsertStatement.java#L89) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/filler/impl/dml/OnDuplicateKeyColumnsFiller.java](https://coveralls.io/builds/28775371/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Ffiller%2Fimpl%2Fdml%2FOnDuplicateKeyColumnsFiller.java#L32) | 1 | 3 | 33.33%
<!-- | **Total:** | **13** | **16** | **81.25%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/src/main/java/org/apache/shardingsphere/orchestration/internal/util/IpUtils.java](https://coveralls.io/builds/28775371/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Finternal%2Futil%2FIpUtils.java#L72) | 2 | 80.0% |
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/rule/registry/ParseRuleRegistry.java](https://coveralls.io/builds/28775371/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Frule%2Fregistry%2FParseRuleRegistry.java#L69) | 11 | 59.26% |
<!-- | **Total:** | **13** | | -->
| Totals | [](https://coveralls.io/builds/28775371) |
| :-- | --: |
| Change from base [Build 9600](https://coveralls.io/builds/28775250): | -0.05% |
| Covered Lines: | 11080 |
| Relevant Lines: | 19226 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services