[GitHub] [druid] ccaominh commented on a change in pull request #9293: Fix early return from YieldingSequenceBase#accumulate.

[GitBox <gi...@apache.org>]

ccaominh commented on a change in pull request #9293: Fix early return from YieldingSequenceBase#accumulate.
URL: https://github.com/apache/druid/pull/9293#discussion_r373124835
 
 

 ##########
 File path: core/src/test/java/org/apache/druid/java/util/common/guava/LimitedSequenceTest.java
 ##########
 @@ -25,45 +25,100 @@
 import org.junit.Test;
 
 import java.util.Arrays;
+import java.util.Iterator;
 import java.util.List;
 import java.util.concurrent.atomic.AtomicLong;
 
 /**
+ *
  */
 public class LimitedSequenceTest
 {
+  private static final List<Integer> NUMS = Arrays.asList(0, 1, 2, 3, 4, 5, 6, 7, 8, 9);
 
 Review comment:
   Looks like this can also be used in `testNoSideEffects()`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org