You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by rg...@apache.org on 2016/01/12 16:18:54 UTC
svn commit: r1724257 -
/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/AttributeValueConverter.java
Author: rgodfrey
Date: Tue Jan 12 15:18:54 2016
New Revision: 1724257
URL: http://svn.apache.org/viewvc?rev=1724257&view=rev
Log:
QPID-6979 : Improve parsing of X509 certificate values
Modified:
qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/AttributeValueConverter.java
Modified: qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/AttributeValueConverter.java
URL: http://svn.apache.org/viewvc/qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/AttributeValueConverter.java?rev=1724257&r1=1724256&r2=1724257&view=diff
==============================================================================
--- qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/AttributeValueConverter.java (original)
+++ qpid/java/trunk/broker-core/src/main/java/org/apache/qpid/server/model/AttributeValueConverter.java Tue Jan 12 15:18:54 2016
@@ -122,6 +122,12 @@ abstract class AttributeValueConverter<T
(String) value);
try
{
+ interpolated = interpolated.replaceAll("\\s","");
+ if(!interpolated.matches("[A-Za-z0-9+/]*[=]*"))
+ {
+ throw new IllegalArgumentException("Cannot convert string '"+ interpolated+ "'to a byte[] - it does not appear to be base64 data");
+ }
+
return DatatypeConverter.parseBase64Binary(interpolated);
}
catch(ArrayIndexOutOfBoundsException e)
@@ -175,6 +181,8 @@ abstract class AttributeValueConverter<T
else if(value instanceof String)
{
String strValue = AbstractConfiguredObject.interpolate(object, (String) value);
+ // convert all line endings to UNIX style
+ strValue = strValue.replaceAll("\r\n","\n").replaceAll("\r","\n");
if(strValue.contains(BEGIN_CERTIFICATE))
{
strValue = strValue.substring(strValue.indexOf(BEGIN_CERTIFICATE) + BEGIN_CERTIFICATE.length());
@@ -182,8 +190,13 @@ abstract class AttributeValueConverter<T
{
strValue = strValue.substring(0,strValue.indexOf(END_CERTIFICATE));
}
- strValue = strValue.replaceAll("\\s","");
+ else
+ {
+ // contains begin but not end - invalid
+ return null;
+ }
}
+
return convert(BINARY_CONVERTER.convert(strValue, object),object);
}
else if(value == null)
@@ -197,7 +210,6 @@ abstract class AttributeValueConverter<T
}
};
-
static final AttributeValueConverter<Long> LONG_CONVERTER = new AttributeValueConverter<Long>()
{
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org