[jira] [Commented] (HUDI-2257) Add a note to set keygenerator class while deleting data

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HUDI-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392310#comment-17392310 ] 

ASF GitHub Bot commented on HUDI-2257:
--------------------------------------

nsivabalan commented on a change in pull request #3375:
URL: https://github.com/apache/hudi/pull/3375#discussion_r681773986



##########
File path: docs/_docs/1_1_spark_quick_start_guide.md
##########
@@ -75,6 +75,7 @@ df.write.format("hudi").
   option(PRECOMBINE_FIELD_OPT_KEY, "ts").
   option(RECORDKEY_FIELD_OPT_KEY, "uuid").
   option(PARTITIONPATH_FIELD_OPT_KEY, "partitionpath").
+  option(KEYGENERATOR_CLASS_PROP, "org.apache.hudi.keygen.SimpleKeyGenerator").

Review comment:
       Can we remove this entry. We want to keep the number of configs small in quick start. May be in the "Note" section, you can call out that, default value for key gen prop is SimpleKeyGen which is what is being used for quick start in general. But if someone is interested in non-partitioned key gen, please use NonpartitionedKeyGenerator. Also, you can link to the key gen blog for someone to refer to all diff key gens supported




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add a note to set keygenerator class while deleting data
> --------------------------------------------------------
>
>                 Key: HUDI-2257
>                 URL: https://issues.apache.org/jira/browse/HUDI-2257
>             Project: Apache Hudi
>          Issue Type: Improvement
>          Components: Docs
>            Reporter: Vinay
>            Assignee: Vinay
>            Priority: Minor
>              Labels: pull-request-available
>
> Copying examples from this blog [https://hudi.apache.org/blog/delete-support-in-hudi/] , does not work as is for Non-Partitioned table, user have to explicitly set the following option in order for delete to work
> {code:java}
> option("hoodie.datasource.write.keygenerator.class","org.apache.hudi.keygen.NonpartitionedKeyGenerator")
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)