You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ijuma (via GitHub)" <gi...@apache.org> on 2023/06/21 14:06:35 UTC

[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

ijuma commented on code in PR #12948:
URL: https://github.com/apache/kafka/pull/12948#discussion_r1237064294


##########
clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java:
##########
@@ -291,7 +291,7 @@ public long skip(long toSkip) throws IOException {
         // Skip bytes stored in intermediate buffer first
         int avail = count - pos;
         long bytesSkipped = (avail < remaining) ? avail : remaining;
-        pos += bytesSkipped;
+        pos += (int) bytesSkipped;

Review Comment:
   This is the main blocker remaining before this PR can be non draft.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org