You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2016/01/05 00:12:28 UTC
Re: Review Request 41377: HIVE-12528 don't start HS2 Tez sessions in a
single thread
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41377/
-----------------------------------------------------------
(Updated Jan. 4, 2016, 11:12 p.m.)
Review request for hive, Gunther Hagleitner and Siddharth Seth.
Repository: hive-git
Description
-------
see JIRA
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ffe0d9a
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java e8864ae
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 3bfe35a
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java a2791a1
Diff: https://reviews.apache.org/r/41377/diff/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 41377: HIVE-12528 don't start HS2 Tez sessions in a
single thread
Posted by Siddharth Seth <ss...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41377/#review115473
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java (line 145)
<https://reviews.apache.org/r/41377/#comment176452>
This exception is not propagated anywhere ? In the single thread case - an Exception from start is propagated upwards (where I'm assuming it is handled to shutdown HiveServer or some such).
Thread uncaughtExceptionHandler / Callable with a ThreadPoolExecutor ?
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java (line 206)
<https://reviews.apache.org/r/41377/#comment176450>
Is this statement still valid ? If not, please delete or modify accordingly.
- Siddharth Seth
On Jan. 4, 2016, 11:12 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41377/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 11:12 p.m.)
>
>
> Review request for hive, Gunther Hagleitner and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see JIRA
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ffe0d9a
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java e8864ae
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 3bfe35a
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java a2791a1
>
> Diff: https://reviews.apache.org/r/41377/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 41377: HIVE-12528 don't start HS2 Tez sessions in a
single thread
Posted by Siddharth Seth <ss...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41377/#review115481
-----------------------------------------------------------
Ship it!
Other than the minor changes around the comment, and Exception propagation - looks good to me.
- Siddharth Seth
On Jan. 4, 2016, 11:12 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41377/
> -----------------------------------------------------------
>
> (Updated Jan. 4, 2016, 11:12 p.m.)
>
>
> Review request for hive, Gunther Hagleitner and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see JIRA
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java ffe0d9a
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java e8864ae
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 3bfe35a
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java a2791a1
>
> Diff: https://reviews.apache.org/r/41377/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 41377: HIVE-12528 don't start HS2 Tez sessions in a
single thread
Posted by Siddharth Seth <ss...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41377/#review115890
-----------------------------------------------------------
Ship it!
Ship It!
- Siddharth Seth
On Jan. 21, 2016, 12:27 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41377/
> -----------------------------------------------------------
>
> (Updated Jan. 21, 2016, 12:27 a.m.)
>
>
> Review request for hive, Gunther Hagleitner and Siddharth Seth.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see JIRA
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32049eb
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java e8864ae
> ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 3bfe35a
> ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java a2791a1
>
> Diff: https://reviews.apache.org/r/41377/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 41377: HIVE-12528 don't start HS2 Tez sessions in a
single thread
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41377/
-----------------------------------------------------------
(Updated Jan. 21, 2016, 12:27 a.m.)
Review request for hive, Gunther Hagleitner and Siddharth Seth.
Repository: hive-git
Description
-------
see JIRA
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 32049eb
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/DagUtils.java e8864ae
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java 3bfe35a
ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java a2791a1
Diff: https://reviews.apache.org/r/41377/diff/
Testing
-------
Thanks,
Sergey Shelukhin