[GitHub] [superset] michael-s-molina commented on a diff in pull request #19521: refactor: Removes the CSS files from the Partition plugin

[GitBox <gi...@apache.org>]

michael-s-molina commented on code in PR #19521:
URL: https://github.com/apache/superset/pull/19521#discussion_r843806881


##########
superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.js:
##########
@@ -274,7 +273,7 @@ function Icicle(element, props) {
             '<tr>' +
             '<td>' +
             '<div ' +
-            `style='border: 2px solid ${atNode ? 'black' : 'transparent'};` +
+            `style='border: 2px solid ${atNode ? 'white' : 'transparent'};` +

Review Comment:
   Nice catch! I removed the condition and used the transparent border to always show the partition's colors. Previously, when the user was hovering over a partition, the leaf was white. Now the leaf obeys the color of the partition. I think it's more intuitive.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org