You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "hughhhh (via GitHub)" <gi...@apache.org> on 2023/02/15 20:07:41 UTC
[GitHub] [superset] hughhhh commented on a diff in pull request #20876: feat: Frontend tagging
hughhhh commented on code in PR #20876:
URL: https://github.com/apache/superset/pull/20876#discussion_r1107667613
##########
superset-frontend/src/explore/components/PropertiesModal/index.tsx:
##########
@@ -314,6 +421,26 @@ function PropertiesModal({
)}
</StyledHelpBlock>
</FormItem>
+ {isFeatureEnabled(FeatureFlag.TAGGING_SYSTEM) && (
+ <h3 style={{ marginTop: '1em' }}>{t('Tags')}</h3>
Review Comment:
can we address this concern? @cccs-RyanK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org